Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save intercepted requests by default if NODE_ENV=test #348

Open
diego-aquino opened this issue Aug 24, 2024 · 0 comments
Open

Save intercepted requests by default if NODE_ENV=test #348

diego-aquino opened this issue Aug 24, 2024 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers
Milestone

Comments

@diego-aquino
Copy link
Member

diego-aquino commented Aug 24, 2024

I'm no longer sure if it's worth to support this. I firmly believe each Zimic default setting should encourage developers to the right thing from the start. By using saveRequests: NODE_ENV === 'test' by default, we could create memory leaks if the process is started with NODE_ENV=test but does perform any calls to interceptor.clear().

@diego-aquino diego-aquino converted this from a draft issue Aug 24, 2024
@diego-aquino diego-aquino added the feature New feature or request label Aug 24, 2024
@diego-aquino diego-aquino added this to the v0.10.0 milestone Aug 24, 2024
@diego-aquino diego-aquino self-assigned this Aug 24, 2024
@diego-aquino diego-aquino modified the milestones: v0.10.0, v0.11.0 Sep 3, 2024
@diego-aquino diego-aquino changed the title Save intercepted requests by default if NODE_ENV=test Save intercepted requests by default if NODE_ENV=test? Sep 8, 2024
@diego-aquino diego-aquino changed the title Save intercepted requests by default if NODE_ENV=test? Save intercepted requests by default if NODE_ENV=test Sep 8, 2024
@diego-aquino diego-aquino added the wontfix This will not be worked on label Sep 8, 2024
@diego-aquino diego-aquino removed this from the v0.11.0 milestone Sep 8, 2024
@diego-aquino diego-aquino removed the status in Zimic Sep 8, 2024
@diego-aquino diego-aquino removed their assignment Sep 8, 2024
@diego-aquino diego-aquino added not sure and removed wontfix This will not be worked on labels Sep 8, 2024
@diego-aquino diego-aquino moved this to Backlog in Zimic Sep 8, 2024
@diego-aquino diego-aquino moved this from Backlog to To do in Zimic Oct 3, 2024
@diego-aquino diego-aquino added this to the v0.12.0 milestone Oct 3, 2024
@diego-aquino diego-aquino self-assigned this Oct 10, 2024
@diego-aquino diego-aquino removed their assignment Nov 1, 2024
@diego-aquino diego-aquino modified the milestones: v0.12.0, v0.13.0 Nov 15, 2024
@diego-aquino diego-aquino modified the milestones: v0.13.0, v0.14.0 Dec 5, 2024
@diego-aquino diego-aquino closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Zimic Jan 23, 2025
@diego-aquino diego-aquino removed this from the v0.14.0 milestone Jan 23, 2025
@diego-aquino diego-aquino removed this from Zimic Jan 23, 2025
@diego-aquino diego-aquino reopened this Feb 7, 2025
@diego-aquino diego-aquino added this to the v0.14.0 milestone Feb 7, 2025
@diego-aquino diego-aquino moved this to To do in Zimic Feb 7, 2025
@diego-aquino diego-aquino added the good first issue Good for newcomers label Feb 8, 2025
@diego-aquino diego-aquino modified the milestones: v0.14.0, v0.15.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
Status: To do
Development

No branches or pull requests

1 participant