-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider type local
as the default interceptor type
#403
Comments
I think it is a nice thing to do, this appears to me a good first contribution, is this task open to contribute ? |
local
as the default interceptor type?local
as the default interceptor type
Hey, @emanamoura! Thanks for the interest in contributing to Zimic! Right now, I'm working on the following issues to make it easier to contribute:
The most important one is the contributing guide showing how to fork and run the project, an overview of the packages and architecture, and our philosophies and guidelines. Would you like to wait for them before taking implementation tasks? I expect to add the contributing guide and the issues/discussions templates by next week. In the meantime, there are two tasks related to the documentation and the examples that may be good first issues too. Let me know if you are interested in working on them. |
Hi @diego-aquino , yes ! I can wait. Could I get #406 ? |
We could simplify our API to consider
type: 'local'
by default when creating an interceptor, makingtype
an optional parameter.Pros:
Cons:
type: 'remote'
existsTo help with the only con I see, we could improve our documentation to encourage starting with a local interceptor, without passing any
type
, and point to other pages explaining advanced use cases with local and remote interceptors.The text was updated successfully, but these errors were encountered: