From e9eb598c6178ceafc55db595d9e7789915a70937 Mon Sep 17 00:00:00 2001
From: Nitish <nitish@zingg.ai>
Date: Mon, 16 Sep 2024 18:09:37 +0530
Subject: [PATCH] refactored

---
 .../main/java/zingg/common/client/ZFrame.java | 21 ------------------
 .../java/zingg/spark/client/SparkFrame.java   | 22 ++++++++++++++++---
 2 files changed, 19 insertions(+), 24 deletions(-)

diff --git a/common/client/src/main/java/zingg/common/client/ZFrame.java b/common/client/src/main/java/zingg/common/client/ZFrame.java
index 7da1753f5..88072a12a 100644
--- a/common/client/src/main/java/zingg/common/client/ZFrame.java
+++ b/common/client/src/main/java/zingg/common/client/ZFrame.java
@@ -185,26 +185,5 @@ public interface ZFrame<D, R, C> {
 
     public ZFrame<D, R, C> transpose(String pivotColumn);
 
-    public ZFrame<D, R, C> addAutoIncrementalRow();
-
     public void showVertical();
-
-    /***
-     * return new ZFrame with new Column added as PIVOT used for transposing the matrix
-     * @param records
-     * @return header included zFrame
-     */
-    default ZFrame<D, R, C> getHeaderIncludedDataFrame(ZFrame<D, R, C> records) {
-        ZFrame<D, R, C> orderedRowAdded = records.addAutoIncrementalRow();
-
-        ZFrame<D, R, C> firstRecord = orderedRowAdded.limit(1);
-        ZFrame<D, R, C> secondRecord = orderedRowAdded.except(firstRecord).limit(1);
-        ZFrame<D, R, C> thirdRecord = orderedRowAdded.except(firstRecord.union(secondRecord));
-
-        //return new ZFrame with Field column added to be used as pivot
-        return firstRecord.withColumn(PIVOT_COLUMN, VALUE_1).
-                union(secondRecord.withColumn(PIVOT_COLUMN, VALUE_2)).
-                union(thirdRecord.withColumn(PIVOT_COLUMN, ORDER));
-    }
-
 }
diff --git a/spark/client/src/main/java/zingg/spark/client/SparkFrame.java b/spark/client/src/main/java/zingg/spark/client/SparkFrame.java
index ca546aa15..fd983bb6d 100644
--- a/spark/client/src/main/java/zingg/spark/client/SparkFrame.java
+++ b/spark/client/src/main/java/zingg/spark/client/SparkFrame.java
@@ -489,8 +489,7 @@ public ZFrame<Dataset<Row>, Row, Column> transpose(String pivotColumn) {
      * @return ZFrame
      */
 
-    @Override
-    public ZFrame<Dataset<Row>, Row, Column> addAutoIncrementalRow() {
+    private ZFrame<Dataset<Row>, Row, Column> addAutoIncrementalRow() {
         String[] columns = df.columns();
         Dataset<Row> temporaryDF = df.limit(1);
         List<String> monotonicIncreasing = new ArrayList<>();
@@ -508,9 +507,26 @@ public ZFrame<Dataset<Row>, Row, Column> addAutoIncrementalRow() {
     public void showVertical() {
         ZFrame<Dataset<Row>, Row, Column> headerIncludedFrame = getHeaderIncludedDataFrame(new SparkFrame(df));
         ZFrame<Dataset<Row>, Row, Column> vertical = headerIncludedFrame.transpose(PIVOT_COLUMN);
-        vertical.sortAscending(ORDER).drop(ORDER).show();
+        vertical.sortAscending(ORDER).drop(ORDER).show(1000);
     }
 
+    /***
+     * return new ZFrame with new Column added as PIVOT used for transposing the matrix
+     * @param records
+     * @return header included zFrame
+     */
+    private ZFrame<Dataset<Row>, Row, Column> getHeaderIncludedDataFrame(ZFrame<Dataset<Row>, Row, Column> records) {
+        ZFrame<Dataset<Row>, Row, Column> orderedRowAdded = addAutoIncrementalRow();
+
+        ZFrame<Dataset<Row>, Row, Column> firstRecord = orderedRowAdded.limit(1);
+        ZFrame<Dataset<Row>, Row, Column> secondRecord = orderedRowAdded.except(firstRecord).limit(1);
+        ZFrame<Dataset<Row>, Row, Column> thirdRecord = orderedRowAdded.except(firstRecord.union(secondRecord));
+
+        //return new ZFrame with Field column added to be used as pivot
+        return firstRecord.withColumn(PIVOT_COLUMN, VALUE_1).
+                union(secondRecord.withColumn(PIVOT_COLUMN, VALUE_2)).
+                union(thirdRecord.withColumn(PIVOT_COLUMN, ORDER));
+    }
 
 }