Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building a Body from Form is too slow #3289

Open
hearnadam opened this issue Feb 3, 2025 · 0 comments
Open

Building a Body from Form is too slow #3289

hearnadam opened this issue Feb 3, 2025 · 0 comments

Comments

@hearnadam
Copy link

Form -> QueryParams reallocates heavily:

https://github.com/zio/zio-http/blob/main/zio-http/shared/src/main/scala/zio/http/Form.scala#L162-L167
https://github.com/zio/zio-http/blob/main/zio-http/shared/src/main/scala/zio/http/internal/QueryModifier.scala#L43

Likely necessary to introduce a builder internally to avoid generating so many (single element) collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hearnadam