Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node's packages.json #1

Open
EHLOVader opened this issue May 2, 2019 · 2 comments
Open

Add support for node's packages.json #1

EHLOVader opened this issue May 2, 2019 · 2 comments

Comments

@EHLOVader
Copy link

Would be nice to use this in npm also
@sun sun mentioned this issue May 3, 2019
Open
@sun
Copy link
Member

sun commented May 3, 2019

@EHLOVader Good idea! Here is a PR: #2. Can you help to review it and confirm that this should work as advertised in the new readme?

@EHLOVader
Copy link
Author

Oh boy, I am sorry I missed the comment here. I did just test and neither NPM or Yarn appear to sort it, but I also couldn't simply install from the package repo. It looks good though.

I added "zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz-no-trailing-comma": "git://github.com/zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz/no-trailing-comma.git#npm-package-sun", to my dependencies. It installed fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sun @EHLOVader