Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) #2690

Merged
merged 22 commits into from
Oct 31, 2023
Merged

Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) #2690

merged 22 commits into from
Oct 31, 2023

Conversation

agnusmor
Copy link
Contributor

@agnusmor agnusmor commented Oct 19, 2023 •
edited
Loading

Closes #2596

What does this PR do?

Do changes in the effective gas price implementation to match redefined process workflow. Check related issue for details

The following configuration parameters has been added:

[Pool.EffectiveGasPrice]
Enabled = true
L1GasPriceFactor = 0.25
ByteGasCost = 16
ZeroByteGasCost = 4
NetProfit = 1
BreakEvenFactor = 1.1
FinalDeviationPct = 10

The following configuration parameters has beed deleted:

[Sequencer.EffectiveGasPrice]
MaxBreakEvenGasPriceDeviationPercentage = 10
L1GasPriceFactor = 0.25
ByteGasCost = 16
MarginFactor = 1
Enabled = false

Reviewers

Main reviewers:

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2023
@agnusmor agnusmor changed the title Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) [DRAFT] Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) Oct 19, 2023
@agnusmor agnusmor added this to the v0.4.0 milestone Oct 19, 2023
@agnusmor agnusmor self-assigned this Oct 23, 2023
ToniRamirezM
ToniRamirezM requested changes Oct 30, 2023
View reviewed changes
pool/pool.go Outdated Show resolved Hide resolved
proto/src/proto/executor/v1/executor.proto Show resolved Hide resolved
proto/src/proto/executor/v1/executor.proto Show resolved Hide resolved
proto/src/proto/executor/v1/executor.proto Show resolved Hide resolved
proto/src/proto/executor/v1/executor.proto Show resolved Hide resolved
sequencer/finalizer.go Outdated Show resolved Hide resolved
pool/effectivegasprice.go Outdated Show resolved Hide resolved
sequencer/finalizer.go Outdated Show resolved Hide resolved
state/types.go Show resolved Hide resolved
@agnusmor agnusmor marked this pull request as ready for review October 31, 2023 00:12
@agnusmor agnusmor changed the title [DRAFT] Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula) Oct 31, 2023
@agnusmor agnusmor merged commit d16f73d into develop Oct 31, 2023
17 checks passed
@agnusmor agnusmor deleted the feature/egp-changes branch October 31, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@tclemos tclemos Awaiting requested review from tclemos tclemos is a code owner

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 is a code owner

@joanestebanr joanestebanr Awaiting requested review from joanestebanr joanestebanr is a code owner

@dpunish3r dpunish3r Awaiting requested review from dpunish3r

Assignees

@agnusmor agnusmor

Labels
cla-signed config zkevm-bridge-sync-rpc zkevm-seq-agg
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Improve effective gas price implementation (RPC filter, gasprice/balance opcodes flags, new formula)
3 participants
@agnusmor @ToniRamirezM @joanestebanr