Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e group 10 (forced batches) #2750

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Fix e2e group 10 (forced batches) #2750

merged 14 commits into from
Nov 9, 2023

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Nov 3, 2023 •
edited
Loading

Closes #2748

What does this PR do?

  • Import fixes from ARR552 in PR Feature/#2669 lx ly #2694 (wrong address for tests)
  • Fix a bad usage of function GetLatestGer that provoke an error if the test takes longer to finish
  • Refactor some code to avoid duplicated code and reduce the complexity

Reviewers

Main reviewers:

@joanestebanr joanestebanr self-assigned this Nov 3, 2023
@joanestebanr joanestebanr requested a review from tclemos as a code owner November 3, 2023 13:53
@cla-bot cla-bot bot added the cla-signed label Nov 3, 2023
@joanestebanr joanestebanr modified the milestones: v0.6.0, v0.5.0 Nov 6, 2023
@joanestebanr joanestebanr merged commit 4e0e957 into develop Nov 9, 2023
17 checks passed
@joanestebanr joanestebanr deleted the feature/2748-improve_e2e_group_10 branch November 9, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@tclemos tclemos Awaiting requested review from tclemos tclemos is a code owner

@agnusmor agnusmor Awaiting requested review from agnusmor agnusmor is a code owner

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 is a code owner

Assignees

@joanestebanr joanestebanr

Labels
cla-signed test zkevm-bridge-sync-rpc
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Improve e2e group 10 (forced batches) to reduce the failing rate
2 participants
@joanestebanr @ToniRamirezM