Update/wp framework #268
Merged
Update/wp framework #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are currently failing because the wp-framework repo is not public |
fabiankaegy
reviewed
Jan 9, 2025
Co-authored-by: Fabian Kägy <[email protected]>
fabiankaegy
reviewed
Jan 20, 2025
| printf( | ||
| '<div class="%1$s"><p>%2$s</p></div>', | ||
| esc_attr( $class ), | ||
| wp_kses_post( __( 'Please ensure the <code>10up/wp-framework</code> composer package is installed.', 'tenup-plugin' ) ) |
There was a problem hiding this comment.
Can we make this link to the GitHub repo?
tlovett1
approved these changes
Jan 20, 2025
dsawardekar
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
@darylldoyle This looks great—approved! Just one minor suggestion:
Instead of ^1.0.0, I recommend using ~1.0.0. For framework-level changes, this helps signal if there are any breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The current implementation of WP-Scaffold includes numerous components (e.g., Abstract Post Types, Abstract Taxonomies, Module Loaders) that often don't require direct maintenance by project teams. While this structure facilitates rapid, iterative releases, it places the burden of updating these components on individual project teams after initialising a scaffold-based project.
This PR integrates the new https://github.com/10up/wp-framework/ package into the scaffold. The framework aims to remove much of the project-agnostic functionality from the scaffold so that it can be updated and maintained separately.
Splitting the scaffold into a core repository and a separate framework package offers significant advantages in terms of security, scalability, standardisation, and the ability to push updates seamlessly across projects. This approach ensures all projects can benefit from centralised improvements while allowing teams the flexibility to customise for unique needs.
Things still to do
wp-frameworkrepo and add to packagistdev-trunkHow to test the Change
Changelog Entry
Credits
Props @darylldoyle
Checklist: