LG-15294: Integrate Flow Policy with IPP steps - State ID and Address

[jennyverdeyen]

🎫 Ticket

Link to the relevant ticket:
LG-15294

🛠 Summary of changes

During FSM clean-up we discovered that the flow policy was not yet being fully used within the in_person/state_id_controller and in_person/address_controller. The step_info was included but it wasn't yet being called. These changes address that by adding the confirm_step_allowed before_action and refactoring the undo_step lambdas in both the state_id_controller and address_controller, so they could be properly called in the clear_future_steps! Flow Policy step.

📜 Testing Plan

There is no new or changed functionality for manual testing - you will want to test the IPP flow to make sure everything is working as usual.

• Enter through sinatra, choosing identity-verified for level of service
• Begin through the in-person flow, stopping at document_capture
• Try to change the url to /verify/in_person/state_id - there is no establishing enrollment yet so the precondition should fail and you should be redirected to document_capture.
• Continue through /document_capture and arrive at /in_person/state_id. Do not submit state id yet.
• Try to change the url to /verify/in_person/address. Because the state id step is not completed yet, the precondition should fail and you should be redirected to state_id.
• Continue through the in-person flow and successfully create an enrollment.

[eileen-nava]

Approved! I did leave feedback about specs, and would be curious to see your response.

[eileen-nava]

Since you added before_action :confirm_step_allowed to the address_controller, would you be up for adding a related expectation? (I was also going to say that the separate expect statements here could be combined. However, I looked through the codebase, and it doesn't look like we have a set pattern of having one expect statement for multiple before actions, or having separate expect statements for each before action. Either way is fine by me.)

[eileen-nava]

I left a similar comment on another controller spec: what are your thoughts on adding an expectation to check for the before_action confirm_step_allowed?