-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-15559: Add support for A/B tests daily reporting #11835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, A/B Tests, Add support for A/B tests daily reporting
zachmargolis
reviewed
Feb 3, 2025
zachmargolis
reviewed
Feb 4, 2025
zachmargolis
reviewed
Feb 4, 2025
zachmargolis
reviewed
Feb 4, 2025
Co-authored-by: Zach Margolis <[email protected]>
Co-authored-by: Zach Margolis <[email protected]>
zachmargolis
reviewed
Feb 5, 2025
matthinz
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-15559
🛠 Summary of changes
Adds the ability to generate email reports for A/B test results to be sent to a team contact email on a regular basis.
This is intended to help:
📜 Testing Plan
End-to-end testing is difficult, but you can verify that the report generates with expected tabular data with AWS-authenticated manual script execution.
Example:
Observe:
Verify that running the job class's
perform
method does not produce any errors. There are currently on A/B tests configured to use this feature, so no queries should be expected to be run.