Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: simplify some statements for readability #169

Merged
merged 1 commit into from
Dec 26, 2024
Merged

style: simplify some statements for readability #169

merged 1 commit into from
Dec 26, 2024

Conversation

hamirmahal
Copy link
Contributor

Closes #168

hamirmahal
hamirmahal commented Dec 20, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't result in any user-facing changes. The goal here is to improve maintainability.

@complexspaces
Copy link
Collaborator

Hey there, thanks for the tidyup PR.

Please rebase your branch onto the latest master to pick up #170, which should fix baseline CI for you.

@hamirmahal
Copy link
Contributor Author

You're welcome. I'll do that right now.

@hamirmahal hamirmahal force-pushed the style/simplify-some-statements-for-readability branch from e9f1239 to c69ce9a Compare December 26, 2024 19:39
@complexspaces complexspaces merged commit e458e1a into 1Password:master Dec 26, 2024
11 checks passed
@hamirmahal hamirmahal deleted the style/simplify-some-statements-for-readability branch December 26, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@complexspaces complexspaces complexspaces approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some statements can be simplified
2 participants
@hamirmahal @complexspaces