Skip to content

Commit

Permalink
change attribute names
Browse files Browse the repository at this point in the history
color to topColor
src to topSrc
bevelColor to color
bevelSrc to src
  • Loading branch information
Algorush committed Mar 30, 2024
1 parent a3d4a15 commit 246ae1e
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/components/svg-extruder.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ AFRAME.registerComponent('svg-extruder', {
bevelOffset: { type: 'number', default: 1 },
bevelSegments: { type: 'number', default: 1 },
topElement: { type: 'boolean', default: false },
color: { type: 'color', default: 'white' },
src: { type: 'string', default: '#grass-texture' },
bevelColor: { type: 'color', default: 'grey' },
bevelSrc: { type: 'string', default: '' },
topColor: { type: 'color', default: 'white' },
topSrc: { type: 'string', default: '#grass-texture' },
color: { type: 'color', default: 'grey' },
src: { type: 'string', default: '' },
lineColor: { type: 'color', default: 'black' }
},
init: function () {
Expand Down Expand Up @@ -44,7 +44,7 @@ AFRAME.registerComponent('svg-extruder', {

// create a mesh with the shape geometry
const mergedShapeMesh = new THREE.Mesh(mergedGeometry,
this.materialFromSrc(data.src, data.color));
this.materialFromSrc(data.topSrc, data.topColor));

if (topElement.getObject3D('mesh')) {
topElement.removeObject3D('mesh');
Expand Down Expand Up @@ -130,7 +130,7 @@ AFRAME.registerComponent('svg-extruder', {

// Finally, create a mesh with the merged geometry
const mergedMesh = new THREE.Mesh(mergedGeometry,
this.materialFromSrc(data.bevelSrc, data.bevelColor)
this.materialFromSrc(data.src, data.color)
);

// remove existing mesh from entity
Expand All @@ -139,7 +139,7 @@ AFRAME.registerComponent('svg-extruder', {
}
el.setObject3D('mesh', mergedMesh);

// el.setAttribute('material', `src:${data.bevelSrc};roughness:1;repeat: 0.1 0.1`);
// el.setAttribute('material', `src:${data.src};roughness:1;repeat: 0.1 0.1`);

const topElement = this.el.children[0];
if (data.topElement) {
Expand Down

0 comments on commit 246ae1e

Please sign in to comment.