Fix scene save right after creation #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
commented
Jan 11, 2025
| @@ -2,8 +2,6 @@ | |||
| import useStore from '../store.js'; | |||
| var streetplanUtils = require('../streetplan/streetplan-utils.js'); | |||
|
|
|||
| const state = useStore.getState(); | |||
There was a problem hiding this comment.
Be careful useStore.getState() returns a snapshot of the state.
| @@ -171,7 +189,9 @@ export async function saveScene(currentUser, doSaveAs) { | |||
| export async function saveSceneWithScreenshot(currentUser, doSaveAs) { | |||
| const currentSceneId = await saveScene(currentUser, doSaveAs); | |||
| if (currentSceneId) { | |||
| makeScreenshot(); | |||
| // wait a bit for models to be loaded, may not be enough... | |||
| await new Promise((resolve) => setTimeout(resolve, 2000)); | |||
There was a problem hiding this comment.
I didn't have any issue locally, but I added that to wait a bit for models to be all loaded before taking the screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1013 fixing several issues: duplicate scene saved, title not saved, positions not saved, blank screenshot