-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(SSR): explicitly load KtNavbar as a component
A change in the template of NavBar.vue produced a very hard to trace down bug which caused the navbar to not render in the documentation. Although the source of this bug could not be made out, it seemed to have to do with how nuxt is resolving components. Adding an explicit import of KtNavbar in the file (and therefore not relying on the kotti-ui plugin for nuxt) fixes this. As the file change that triggered this is very unrelated and it would be impossible to see this very unrelated effect in code review, a test was added that should at least stop the very same event to occur Co-Authored-By: Florian Wendelborn <[email protected]>
- Loading branch information
1 parent
c4fa4a9
commit 272b01b
Showing
4 changed files
with
14 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/usr/bin/env bash | ||
|
||
set -euo pipefail | ||
|
||
if grep '</ktnavbar>' ./dist/index.html; | ||
then echo "The output of nuxt contains a 'ktnavbar' tag, this might be the result of a strange SSR bug" && false; | ||
else true; | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters