Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data tests to standard table #1039

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add data tests to standard table #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8d395
fix(KtStandardTable): add data-test attributes to buttons in kt-stand…
Isokaeder Jan 14, 2025
6cee7c1
version([email protected]): add data-test to buttons in standard table
Isokaeder Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kotti-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,5 @@
"style": "./dist/style.css",
"type": "module",
"types": "./dist/index.d.ts",
"version": "8.3.1"
"version": "8.3.2"
}
1 change: 1 addition & 0 deletions packages/kotti-ui/source/kotti-table/KtStandardTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<div v-if="!hideTableActions" class="kt-standard-table__table-actions">
<TableSearch
v-if="!options?.hideControls?.search"
data-test="table-search-field"
:isLoading="isLoadingAndEmpty"
:placeholder="options?.searchPlaceholder"
:value="searchValue"
Expand Down
2 changes: 2 additions & 0 deletions packages/kotti-ui/source/kotti-table/standard-table/components/Columns.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
:trigger="isLoading ? 'manual' : 'click'"
>
<KtButton
data-test="table-column-edit-button"
:disabled="isLoading"
:icon="Yoco.Icon.CHEVRON_DOWN"
:isLoading="isLoading"
Expand All @@ -20,6 +21,7 @@
/>
<!-- FIXME: ideally this button shoud not be behind the fold -->
<KtButton
data-test="table-column-show-all-button"
:disabled="isShowAllDisabled"
:label="translations.showAll"
type="text"
Expand Down
3 changes: 2 additions & 1 deletion packages/kotti-ui/source/kotti-table/standard-table/components/Filters.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
:trigger="isLoading ? 'manual' : 'click'"
>
<KtButton
data-test="table-filter-edit-button"
:disabled="isLoading"
:icon="Yoco.Icon.CHEVRON_DOWN"
:isLoading="isLoading"
Expand All @@ -22,6 +23,7 @@
@input="$emit('input', $event)"
/>
<KtButton
data-test="table-filter-clear-all-button"
:disabled="isLoading"
:label="translations.clearAll"
type="text"
Expand Down Expand Up @@ -53,7 +55,6 @@ export default defineComponent({
type: Array as PropType<KottiStandardTable.FilterInternal[]>,
},
isLoading: { default: false, type: Boolean },

size: { default: 'md', type: String },
value: {
default: () => [],
Expand Down
1 change: 1 addition & 0 deletions packages/kotti-ui/source/kotti-table/standard-table/components/PageSize.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export default defineComponent({
return {
options: computed<KottiFieldSingleSelect.Props['options']>(() =>
props.pageSizeOptions.map((value) => ({
dataTest: `table-page-size-options-${value}`,
label: String(value),
value,
})),
Expand Down
Loading