Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kotti pagination #543

Closed
wants to merge 49 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
334ffd0
refact(kottiPagination): typescript and composition api for parent co…
Isokaeder Oct 14, 2021
e4e2db7
refactor(kottiPagination): add prop types, zod schema and add to expo…
Isokaeder Oct 14, 2021
4f94b34
refact(kottiPagination): brush up css
Isokaeder Oct 14, 2021
626eb99
refact(kottiPagination): remove deprecated prop
Isokaeder Oct 14, 2021
4c2314c
docs(kottiPagination): remove prop table
Isokaeder Oct 14, 2021
4f03cdb
refact(kottiPagination): 'kt-pagination__' prefix for all css classes
Isokaeder Oct 14, 2021
1420772
refactor(kottiPagination): clean up some functions
Isokaeder Oct 14, 2021
ce9772c
fix(kottiPagination): put css variable into root
Isokaeder Oct 14, 2021
91598cb
refact(kotti-pagination): inline function that calculates center of s…
Isokaeder Oct 14, 2021
56080c1
fix(KtPagination): emit right value
Isokaeder Dec 1, 2021
bf9d4cb
fix(KtComment): avatar gets squashed with large comments
carsoli May 3, 2022
802472e
refact(KtComment): move classes around w/o changes
carsoli May 12, 2022
1e85813
feat(KtComment): add translations to edit and delete
carsoli May 13, 2022
0199166
feat(KtComment): add CommentOptions component
carsoli May 13, 2022
fe9874a
fix(CommentActionsOptions): clickbehavior prop
carsoli May 13, 2022
2f96173
feat(KtComment): implement CommentActions and CommentActionsReply
carsoli May 13, 2022
83c0ee2
refact(CommentReply): move classes from _comments.scss
carsoli May 13, 2022
1c453d8
feat(KtCommentInput): prefix classes with `kt-`
carsoli May 13, 2022
e144bc5
feat(KtComment): prefix classes with `kt-`
carsoli May 13, 2022
ee74729
fix(KtComment): fix editing of replies
carsoli May 18, 2022
134d42b
refact(KtComment): use CommentInlineEdit
carsoli May 18, 2022
9d09175
fix(CommentReply): fix props passed to it and add types
carsoli May 18, 2022
3f1bb38
fix(CommentInlineEdit): fix font-size and remove dead css
carsoli May 18, 2022
eaab11e
refact(KtComment): unified edit event - similar to delete
carsoli May 23, 2022
0c29297
fix(KtPopover): not sure why we even need min width
carsoli May 23, 2022
0ed4bab
enhance(CommentInlineEdit): scrollbar styles
carsoli May 24, 2022
1dd00e5
feat(KtComment): parse \n by default in post parser
carsoli May 24, 2022
6a9114c
chore(stylelint): fix
carsoli May 24, 2022
c5bcff2
refact(CommentReply) use css variables
carsoli May 24, 2022
9ca48f6
Revert "refact(CommentReply) use css variables fix translations as well"
carsoli May 25, 2022
a2e0482
Revert "chore(stylelint): fix"
carsoli May 25, 2022
a819a6b
Revert "feat(KtComment): parse \n by default in post parser"
carsoli May 25, 2022
9b3f631
Revert "enhance(CommentInlineEdit): scrollbar styles"
carsoli May 25, 2022
01c63f5
Revert "fix(KtPopover): not sure why we even need min width"
carsoli May 25, 2022
df90dc9
Revert "refact(KtComment): unified edit event - similar to delete"
carsoli May 25, 2022
4fb1a21
Revert "fix(CommentInlineEdit): fix font-size and remove dead css"
carsoli May 25, 2022
b371b32
Revert "fix(CommentReply): fix props passed to it and add types"
carsoli May 25, 2022
6340853
Revert "refact(KtComment): use CommentInlineEdit"
carsoli May 25, 2022
ffcaf5e
Revert "fix(KtComment): fix editing of replies previously, editing wa…
carsoli May 25, 2022
6f0097b
Revert "feat(KtComment): prefix classes with `kt-`"
carsoli May 25, 2022
f030c79
Revert "feat(KtCommentInput): prefix classes with `kt-` move styles t…
carsoli May 25, 2022
9e68054
Revert "refact(CommentReply): move classes from _comments.scss remove…
carsoli May 25, 2022
65ed5e2
Revert "feat(KtComment): implement CommentActions and CommentActionsR…
carsoli May 25, 2022
d9c02ae
Revert "fix(CommentActionsOptions): clickbehavior prop rename Comment…
carsoli May 25, 2022
a317690
Revert "feat(KtComment): add CommentOptions component"
carsoli May 25, 2022
f7b4e64
Revert "feat(KtComment): add translations to edit and delete"
carsoli May 25, 2022
5561c18
Revert "refact(KtComment): move classes around w/o changes"
carsoli May 25, 2022
8016a80
Revert "fix(KtComment): avatar gets squashed with large comments the …
carsoli May 25, 2022
0e56ed5
refact(KottiPagination): typescript and composition api for child com…
Isokaeder Oct 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "fix(KtComment): avatar gets squashed with large comments the …
…comment-wrapper had flex: 1 1 auto changing it to flex: 1 means that it became flex: 1 1 0 the flex-basis is the third property/value changing it to `0` means that the elements WON'T change size after the space is redistributed this guarantees that the comment_wrapper doesn't take more space, ...and therefore squash the avatar"

This reverts commit bf9d4cb.
carsoli committed May 25, 2022
commit 8016a80606caf86be7e1252980949e4d54eda822
2 changes: 1 addition & 1 deletion packages/kotti-ui/source/kotti-style/_comments.scss
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@

.comment__wrapper {
display: flex;
flex: 1;
flex: 1 1 auto;
flex-direction: column;
margin-left: 0.4rem;
}