Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(eslint): add reusable eslint config, create @3yourmind/eslint-config #912

Merged
merged 1 commit into from
May 13, 2024
Merged

feature(eslint): add reusable eslint config, create @3yourmind/eslint-config #912

merged 1 commit into from
May 13, 2024

Conversation

Isokaeder
Copy link
Collaborator

@Isokaeder Isokaeder commented May 7, 2024 •
edited by FlorianWendelborn
Loading

  • add @3yourmind/eslint-config package
    • set to auto-publish from CI
  • replace vue-clipboard2 with copy-to-clipboard
  • remove ts-custom-error in favor of extending the native Error class (which is now possible)

@github-actions github-actions bot added package:kotti-ui @3yourmind/kotti-ui package:vue-use-tippy @3yourmind/vue-use-tippy package:yoco @3yourmind/yoco labels May 7, 2024
@FlorianWendelborn FlorianWendelborn self-requested a review May 7, 2024 15:13
@FlorianWendelborn FlorianWendelborn added the autorebase:opt-in Apply this label to enable automatic rebasing label May 7, 2024
@FlorianWendelborn FlorianWendelborn added autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically labels May 8, 2024
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch from 0d69e2b to 60659e9 Compare May 8, 2024 10:28
@FlorianWendelborn FlorianWendelborn removed the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label May 8, 2024
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch 4 times, most recently from a702f4b to b1f3a96 Compare May 10, 2024 15:45
Isokaeder
Isokaeder commented May 13, 2024
View reviewed changes
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch from b1f3a96 to f670172 Compare May 13, 2024 09:53
@FlorianWendelborn FlorianWendelborn added the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label May 13, 2024
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch from f670172 to ce98b33 Compare May 13, 2024 10:58
@FlorianWendelborn FlorianWendelborn removed the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label May 13, 2024
FlorianWendelborn
FlorianWendelborn approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianWendelborn FlorianWendelborn marked this pull request as ready for review May 13, 2024 12:51
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch from ce98b33 to 9e71ffa Compare May 13, 2024 15:21
@Isokaeder Isokaeder enabled auto-merge May 13, 2024 15:21
@FlorianWendelborn
feature(eslint): add reusable eslint config, create @3yourmind/eslint…
97f613e 
…-config

We could not migrate all existing plugins at this time, see #914

Co-Authored-By: Florian Wendelborn <[email protected]>
@Isokaeder Isokaeder force-pushed the eslint-plugin-3yourmind/mvp branch from 9e71ffa to 97f613e Compare May 13, 2024 15:27
@Isokaeder Isokaeder merged commit 84d6d33 into master May 13, 2024
9 checks passed
@Isokaeder Isokaeder deleted the eslint-plugin-3yourmind/mvp branch May 13, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianWendelborn FlorianWendelborn FlorianWendelborn approved these changes

Assignees
No one assigned
Labels
autorebase:opt-in Apply this label to enable automatic rebasing package:kotti-ui @3yourmind/kotti-ui package:vue-use-tippy @3yourmind/vue-use-tippy package:yoco @3yourmind/yoco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isokaeder @FlorianWendelborn