Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fool CI to migrate to Eaton MBT #163

Open
wants to merge 5 commits into
base: FTY
Choose a base branch
from

Conversation

aquette
Copy link
Member

@aquette aquette commented Jan 20, 2022

No description provided.

@jimklimov
Copy link
Member

jimklimov commented Jan 20, 2022

Generally LGTM, when/if CI does pick it up do check that it runs equivalent tests (note the configure options in the old text) to be sure the build scopes are relevant (DMF generated, etc.) or find a way to propagate those into the build. Also the old recipe should have prepared the (partial?) dist tarball pushed for publication to OBS, most notably the generated man pages as a large time hog for the build (especially comparing to negligible time for C sources vs. ccache'd iterations).

UPDATE: Looking at build log, the step used is configuring specifically for zproject-style builds (e.g. --enable-drafts) that NUT is not too similar to. Notably, it uses --enable-Werror unconditionally, and current 42ity NUT codebase fails that (took a over a year of weekends and holidays to clean up the upstream NUT from several layers of warnings, but 42ity fork's unique code still has a lot ahead to reach the bar). So for now, this setting needs to be changed (different step defined in library for NUT builds?)

See also the ci_build.sh and Jenkinsfile-dynamatrix merged from upstream NUT to automate much of such test-building.

jimklimov and others added 4 commits January 20, 2022 15:06
Fix printing of snmp_info_flags_t
Signed-off-by: Arnaud Quette <[email protected]>
Signed-off-by: Arnaud Quette <[email protected]>
@aquette aquette added the DNMY label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants