Nut driver enumerator optimize (FTY) #81
Open
+541
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led to add a normally-named one because it already exists (clean it up and then add)
…about yet-missing property
…sh the non-instance service (for global config)
…about yet-missing property
… setter into smf_setSavedUniq() for other use-cases
…avoid variable pollution in caller
…" for better readability
…up --get-device-for-service processing where possible
…up --get-device-for-service processing where possible (typo fix)
…r faster --get-service-for-device processing
…F FMRIs more intensively
…ceName data to be consistent (ensuring it is is expensive and belongs elsewhere)
…and upslist_savednames_find_mismatch() to upgrade entries without saved names
…e) and get_device_for_service() into routines
…ssing() into single-run and daemonized modes, to update inconsistent configs
…onfigure() into a routine
…--daemon-after mode
|
DNMY : As agreed, we'll run a test with a system that has many (hundreds range) driver sections defined to measure if this PR brings benefits, and to estimate where to go next in this area. Points of interest:
|
…uotes around returned DEVICE == "..." value
… smf_setSavedUniq() and smf_setSavedMD5()
…turn expected values
…ceName and hook_getSavedDeviceName
|
Note: There are some further improvements staged in a development repo at https://github.com/jimklimov/nut/tree/FTY-upssvc-201904 and not yet PRed because the updated codepaths are not yet integrated with the main codebase to replace earlier implementations. When scheduling allows, I'd proceed on that. |
…ot active for simple and daemon modes currently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 42ity equivalent to networkupstools#682, without the older improvements which are in FTY and are not yet in upstream (part of 682 now).