Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new setting definition called pair #41

Closed
wants to merge 6 commits into from

Conversation

vigneshtdev
Copy link

@vigneshtdev vigneshtdev commented Apr 20, 2019

This commit includes creating a generic Pair model class.

i still need clarification on two aspects:

  1. Is the datatype for the pair variables always going to be string?
  2. How should this show up in settings.json file
  3. What should be default behaviour?

Addresses #11

CI test failing due to unused field, will get fixed once above questions are answered.

@vigneshtdev vigneshtdev closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant