Scalable gearboxes rework #443
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet complete! Please don't try to use this yet if you are a player/server owner lol
- Mobility ropes are now entirely faked with clientside rendering instead of being actual ropes (using actual ropes with scalable entities like this looks awful) - Lowered the minimum scale amount to 0.75 to allow for tiny clutches - The mobility ropes setting now toggles visibility of all mobility ropes globally instead of only allowing the creation of ones owned by the local player - Added some globals for controlling gearbox behavior
For some reason, these were occasionally loading in like normal gearboxes and were selectable from the menu, which was not supposed to happen.
marchc1
requested changes
Dec 24, 2024
There was a problem hiding this comment.
Other than these commented out things I found and that weird menu issue, I don't immediately see anything off? I'll prob do a second pass later.
I tested four of my dupes, ranging from 2020 to 2024, and all seem to still work perfectly fine, so functionally I can't see anything wrong
- Removed lots of commented out chunks - Fixed a bug where the menu would show dual clutch as enabled but the actual setting would be disabled right after opening the menu for the first time - Fixed (?) a bug where the gearbox entity in the menu would throw an error after opening the page for the first time (I just increased the timer a bit) - Allowed 9 gear auto/manual boxes
Removed the extra DrawRope calls since calling it in the draw hook just made every single mobility component draw the ropes again and again Also start paving the way for eventually optionally generating a model for links in place of the simple ropes
Extends the gear ratio limits to -10:10 and inverts them relative to the existing ones. Based loosely on work by @Tyunge
|
This rework now also includes more realistic gear ratios as requested in #250 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100 and #250
Partial completion of #15
This PR contains a significant overhaul of gearboxes to turn them into customizable scalable entities. Some of the features include:
Use this at your own risk if you want to test it, as things should still be considered experimental and potentially unstable/breaking until this gets into the main branch.
Things still left to be done: