This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Adding the possibility to explicitly omit the the request-id #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it would be useful to explicitly omit the
idparam from a JSON-RPC request.The JSON-RPC specification defines a request without the
idmember as the special "Notification" request type (see 4.1).I guess the easiest way to do this, is to allow passing
NSNullas therequestId. In that case, the request would explicitly not contain theidfield. UsingNSNullfor that, allows also to keep the current default, where the id gets set to '1' ifnilwas passed.