testing: some changes requested in review session

- rename proc/10-tests_pre.sh to proc-tests_scan
- rename ABTEST_USEDEFAULT to ABTEST_AUTO_DETECT
- add a small banner on start and end for autobuild-test
- improve configurability for auto detected custom tests

contrib/autobuild-test

@@ -1,21 +1,23 @@
 #!/bin/bash
 # autobuild-test: seperated bash instance for tests
 
+if [[ $# -eq 0 ]]; then
+    TEST=default
+else
+    TEST=$1
+fi
+
 . $AB/lib/diag.sh || { echo "\e[1;91m FATAL: Cannot open stacktrace printing library! exiting."; exit 1; }
 . $AB/lib/base.sh || { echo "\e[1;91m FATAL: Cannot open base library! exiting."; exit 1; }
 . $AB/lib/builtins.sh || { echo "\e[1;91m FATAL: Cannot open utility function library! exiting."; exit 1; }
 
+echo "================= Running autobuild3 test for $TEST ================="
+
 . $AB/proc/10-core_defines.sh || abdie "Cannot load core_defines.sh, exiting ..."
 . $AB/proc/10-env-setup.sh || abdie "Cannot load env-setup.sh, exting ..."
 
 abrequire tests
 
-if [[ $# -eq 0 ]]; then
-    TEST=default
-else
-    TEST=$1
-fi
-
 if [[ "$TEST" == "default" ]]; then
     DEFAULT=yes
 fi
@@ -54,4 +56,5 @@ if [[ $EXIT_CODE -gt 2 ]]; then
     EXIT_CODE=255
 fi
 
+echo "================= Finished autobuild3 test for $TEST ================="
 exit $EXIT_CODE

etc/autobuild/ab3_defcfg.sh

@@ -63,10 +63,11 @@ AB_SAN_LEK=0
 AB_LD_BFD=0
 
 # Default testing flags
-ABTESTS="default"
-ABTEST_USEDEFAULT=no
-ABTEST_TESTEXEC=plain
+ABTESTS=""
+ABTEST_AUTO_DETECT=yes
 ABTEST_ABORT_BUILD=yes
+ABTEST_TESTEXEC=plain
+ABTEST_AUTO_DETECT_STAGE=post-build
 NOTEST=no
 
 ##OS Directory Tree

lib/tests.sh

@@ -127,7 +127,7 @@ abtest_gen_default() {
                 abinfo "Found check script file, using it as default test ..."
                 ABTEST_default_TESTTYPE=custom
                 ABTEST_default_TESTDEPS=$TESTDEPS
-                ABTEST_default_CUSTOM_STAGE=postbuild
+                ABTEST_default_CUSTOM_STAGE=$ABTEST_AUTO_DETECT_STAGE
                 ABTEST_default_CUSTOM_SCRIPT=$SRCDIR/autobuild/check
                 ABTEST_default_CUSTOM_IS_BASHSCRIPT=yes
             else

proc/10-tests_pre.sh → proc/10-tests_scan.sh

@@ -7,17 +7,12 @@ if bool $NOTEST; then
     TESTDEPS="" # Empty TESTDEPS by explicitly override it
 else
     abinfo "Currently enabled tests are: $ABTESTS"
+    abrequire tests
 fi
 
 if [[ -n "$ABTESTS" ]]; then
-    abrequire tests
-
     _IFS="$IFS" IFS=$' '
     for test in $ABTESTS; do
-        if [[ "default" == "$test" ]]; then
-            ABTEST_USEDEFAULT=yes
-            continue
-        fi
         abtest_scanner_load "$test"
 
         local _testdeps="ABTEST_${test}_TESTDEPS"

proc/31-tests_probe.sh

@@ -1,6 +1,9 @@
 #!/bin/bash
 #proc/tests_probe.sh: probe and generate default tests
 
-if bool $ABTEST_USEDEFAULT; then
+if bool $ABTEST_AUTO_DETECT; then
     abtest_gen_default
+    if [[ $? -eq 0 ]]; then
+        ABTESTS="$ABTESTS default"
+    fi
 fi

proc/51-tests_post_build.sh

@@ -1,9 +1,9 @@
 #!/bin/bash
-##proc/tests_postbuild: run tests at post build stage
+##proc/tests_post_build: run tests at post build stage
 ##@copyright GPL-2.0+
 
 for testcase in $ABTESTS; do
-    abtest_run postbuild "${testcase}"
+    abtest_run post-build "${testcase}"
 done
 
 unset testcase

proc/92-tests_post_install.sh

@@ -1,9 +1,9 @@
 #!/bin/bash
-##proc/tests_postbuild: run tests at post install stage
+##proc/tests_post_install: run tests at post install stage
 ##@copyright GPL-2.0+
 
 for testcase in $ABTESTS; do
-    abtest_run postinst "${testcase}"
+    abtest_run post-install "${testcase}"
 done
 
 unset testcase