upgrading packages #625
Merged
upgrading packages #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalwalt
added
documentation
kalwalt
commented
Dec 20, 2024
|
i will make the new release 3.4.6 tomorrow evening if i can. 🙂 |
|
@kalwalt great! |
This was referenced Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It's a small PR adressed to upgrade some packages and to enhance the Readme and more:
HTML Correction:
aframe/examples/location-based/always-face-user/index.htmlby changing<a-entity>to<a-text>..prettierignoreUpdate:.prettierignoreto include.mjsfiles inaframe/buildandthree.js/builddirectories, to avoid check formatting.improved Readme
Added a new section New Import Syntax for
ar-threex.mjsandar.mjsto explain the new standard forthreexrelated code.Can it be referenced to an Issue? If so what is the issue # ?
see #611
How can we test it?
Test the examples (Three.js and Aframe), anyway it shouldn't be any issue because the files are only renamed (the extension).
Summary
Does this PR introduce a breaking change?
No, it shouldn't
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested under Windows 11 Chrome 131.0.6778.140 64bit.
Other information
This is latest PR before make a new release:
3.4.6.