Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CameraUtilICS.java #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rcaboni
Copy link

@rcaboni rcaboni commented Feb 23, 2017

There is a little bug for "old" Android (before 5). I add startPreview and stopPreview to fix it. I try it on Samsung S4 Mini (Android 4.4.4)

There is a little bug for "old" Android (before 5). I add startPreview and stopPreview to fix it. I try it on Samsung S4 Mini (Android 4.4.4)
@Abhi347
Copy link
Owner

Abhi347 commented Feb 27, 2017

@rcaboni Thanks for the fix, but can you please provide some more details about the bug, so that I can test it and check whether it exists on other devices. I also need the details to know whether the fix will affect apps in other Android versions or not.

@rcaboni
Copy link
Author

rcaboni commented Feb 28, 2017

Hi Abhi, the problem is only for Android before LOLLIPOP, indeed i fix the CameraUtilICS file.
The bug is that the only setTorchMode(TorchMode.SwitchedOn); is not enough to turn on the flash but it's essential to call mCamera.startPreview(); too.
Without this the flash don't turn on.
The same fix for turn off the flash.

I check the problem and the fix it on Samsung S3 Mini, S4 Mini, XCover 2.
Before the fix the flash don't turn on in these devices with Android 4.x.
i notice your library that work on all Android version, but without this fix we spoil "old" Android version (still an important piece of market ).

@Changsik00
Copy link

Changsik00 commented Jul 4, 2017

noobCameraManager.init(getActivity(), LogLevel.Verbose);

it was getActivity() not working MainActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants