-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added uinames to ambiguously named nodes #1959
base: main
Are you sure you want to change the base?
Added uinames to ambiguously named nodes #1959
Conversation
@@ -94,7 +94,7 @@ | |||
Node: <generalized_schlick_bsdf> | |||
A reflection/transmission BSDF node based on a microfacet model and a generalized Schlick Fresnel curve. | |||
--> | |||
<nodedef name="ND_generalized_schlick_bsdf" node="generalized_schlick_bsdf" nodegroup="pbr" doc="A reflection/transmission BSDF node based on a microfacet model and a generalized Schlick Fresnel curve."> | |||
<nodedef name="ND_generalized_schlick_bsdf" node="generalized_schlick_bsdf" uiname="Generalized Schlick BSDF" nodegroup="pbr" doc="A reflection/transmission BSDF node based on a microfacet model and a generalized Schlick Fresnel curve."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an opportunity to add Hoffmann to the UI name. Same opportunities for Oren-Nayar and Sheen nodes upgraded for OpenPBR.
@@ -1265,11 +1265,11 @@ | |||
Node: <texcoord> | |||
The full 2D or 3D texture coordinates associated with the currently processed data. | |||
--> | |||
<nodedef name="ND_texcoord_vector2" node="texcoord" nodegroup="geometric"> | |||
<nodedef name="ND_texcoord_vector2" node="texcoord" uiname="Texture Coordinate" nodegroup="geometric"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singular to match with geomcolor
and geompropvalue
which were singular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of introducing consistent uiNames for the nodes - it will allow artists to more easily transition between DCCs without having to do any mental translation of what nodes do.
It did make me a little sad that this information has to be replicated on each <nodedef>
element, and got me to wondering if we need an element that can hold information that relates to the whole node family in one place, to define things like uiName
and possibly nodegroup
on. Not something for this PR, but maybe something for us to think about.
@ld-kerley I like this idea of UI separation / reuse. Throwing out a possible syntax <!-- Associate with a nodedef interface -->
<ui name="UI_def_name" uiname="My UI Name" nodedef="ND_def_name" >
<input name="in1" uigroup="group1" uiname="Input 1" doc="This is the first input" />
<input name="in2" uigroup="group2" uiname="Input 2" doc="This is the second input" />
<output name="out1" uigroup="group2" uiname="Output 2" doc="This is the first output" />
</ui>
<!-- Associate with a compound graph interface -->
<ui name="UI_graph_name" uiname="My UI Graph Name" nodegraph="my graph" >
<input name="in1" uigroup="group1" uiname="Input 1" doc="This is the first graph input" />
<input name="in2" uigroup="group2" uiname="Input 2" doc="This is the second graph input" />
<output name="out1" uigroup="group2" uiname="Output 2" doc="This is the first graph output" />
</ui> Can take this thread outside this PR but thought I'd drop this in as if you want a consistent naming you might also want to consider consistency for input / output names as well. |
I am trying to build UI names for a MaterialX node picker and had to create a hardcoded list of names to expand. Seeing this as not particularly good I wondered if uiname metadata could not be added at the source to add proper display names in cases where they could not be algorithmically generated.
This involves a few editorial decisions. I do not have any strong feelings about these and am open to iterate.
glTF
andOpenPBR
related nodes.ifgreatereq
,premult
, etc).sin
,cos
,atan2
,exp
... probably the worst editorial decision of the bunch, but I plead "best practice" since this is how math is written in textbooks).TODO: Fix this line in usdMtlx parser to try to find
uiname
metadata for theLabel
Sdr metadata.