add MachineEvent.Factory.parse() method #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuhn
commented
Jan 25, 2024
machine-runner/package.json
Outdated
| @@ -68,7 +68,8 @@ | |||
| "fast-equals": "^5.0.1", | |||
| "ts-node": "^10.9.1", | |||
| "typed-emitter": "^2.1.0", | |||
| "typescript": "^4.9.5" | |||
| "typescript": "^4.9.5", | |||
| "zod-validation-error": "^3.0.0" | |||
There was a problem hiding this comment.
you cannot set a dependency to optional AND import it. (import type is a different case)
There was a problem hiding this comment.
Then what is the purpose of optional: true? And what is the pattern for only optionally using a dependency?
There was a problem hiding this comment.
In TypeScript it can be used with import type
In CJS Node code, including packages use require. with require you can do:
// optionally use some module
try {
const module = require("somemodule")
module.someFunction();
} catch (err) {}
Kelerchian
reviewed
Jan 25, 2024
| /* eslint-disable @typescript-eslint/no-var-requires */ | ||
|
|
||
| const ZOD = { | ||
| zod: (await import('zod').catch( |
There was a problem hiding this comment.
TIL await import can be used to export synchronously. Nice trick
| @@ -31,11 +32,70 @@ export type MachineEvent<Key extends string, Payload extends object> = { | |||
| type: Key | |||
| } & Payload | |||
|
|
|||
| type Zod = { | |||
There was a problem hiding this comment.
These should be moved to zod.ts
There was a problem hiding this comment.
Since there are two zod.ts there would be the danger of divergence.
Kelerchian
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.