fix bug caused by late nva state store nullification #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuhn
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Yes, it makes sense to not purge the state when it wasn’t the state from which the command originated. But why do we need to purge upon persistence at all?
Overall it feels to me like all this machinery has grown out of control. Does it really need to be this complex?
machine-runner/src/runner/runner.ts
Outdated
| @@ -859,6 +875,7 @@ namespace NextValueAwaiter { | |||
| consume, | |||
| peek, | |||
| purge, | |||
There was a problem hiding this comment.
That's right. It is no longer used.
| emitter.on('next', nva.push) | ||
| emitter.on('failure', nva.fail) | ||
| emitter.on('commandPersisted', nva.purge) | ||
| emitter.on('commandPersisted', purgeWhenMatching) |
There was a problem hiding this comment.
This started when we observed, during one of Jose's presentation on SW's ActyxServiceBase refactor, that a command call should purge so that subsequent .next/.peekNext call will not be the same state that calls the command.
As for the specific timing of the purge (on persistence), this is the reasoning #92 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.