fetch proposal 76 details from the chain #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Sep 6, 2024
see what you think.
that would involve testing that it works from multiple places. Hm. I guess I could at least mention it in a README or something... |
Chris-Hibbert
approved these changes
Sep 7, 2024
Chris-Hibbert
pushed a commit
that referenced
this pull request
Sep 9, 2024
* chore: automate fetching parts of CoreEval proposal 76 * chore: save complete transaction for proposal 76 * chore: tweak whitespace to match on-chain data * fixup! chore: automate fetching parts of CoreEval proposal 76
Chris-Hibbert
added a commit
that referenced
this pull request
Sep 10, 2024
* test: add 76:vaults-auctions * fetch proposal 76 details from the chain (#175) Co-authored-by: Dan Connolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to verify #172 against what's on chain and found tiny whitespace differences.
Keeping the Makefile may or may not be worthwhile, but I think keeping
tx.jsonis worthwhile.The whitespace diffs in the scripts and permits have no semantic impact on how an agoric-3-proposals chain works, so that's a coin toss.