feat(fast-usdc): skipAdvance when preconditions fail

Agoric · Feb 13, 2025 · 430a488 · 430a488
1 parent 729fe8e
commit 430a488
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 11 deletions.
diff --git a/multichain-testing/test/fast-usdc/fast-usdc.test.ts b/multichain-testing/test/fast-usdc/fast-usdc.test.ts
@@ -658,7 +658,7 @@ test.serial('insufficient LP funds; forward path', async t => {
     await useChain(eudChain).getRestEndpoint(),
   );
 
-  await assertTxStatus(evidence.txHash, 'OBSERVED');
+  await assertTxStatus(evidence.txHash, 'ADVANCE_SKIPPED');
 
   nobleTools.mockCctpMint(mintAmt, userForwardingAddr);
 
@@ -788,7 +788,7 @@ test.serial('insufficient LP funds and forward failed', async t => {
   // submit evidences
   await Promise.all(txOracles.map(async o => o.submit(evidence)));
 
-  await assertTxStatus(evidence.txHash, 'OBSERVED');
+  await assertTxStatus(evidence.txHash, 'ADVANCE_SKIPPED');
 
   nobleTools.mockCctpMint(mintAmt, userForwardingAddr);
 

diff --git a/packages/fast-usdc/src/exos/advancer.js b/packages/fast-usdc/src/exos/advancer.js
@@ -217,7 +217,7 @@ export const prepareAdvancerKit = (
             });
           } catch (error) {
             log('Advancer error:', error);
-            statusManager.observe(evidence);
+            statusManager.skipAdvance(evidence, ['PRECONDITIONS_FAILED']);
           }
         },
         /** @param {ChainAddress} intermediateRecipient */

diff --git a/packages/fast-usdc/test/exos/advancer.test.ts b/packages/fast-usdc/test/exos/advancer.test.ts
@@ -275,7 +275,7 @@ test('updates status to ADVANCING in happy path', async t => {
   ]);
 });
 
-test('updates status to OBSERVED on insufficient pool funds', async t => {
+test('updates status to ADVANCE_SKIPPED on insufficient pool funds', async t => {
   const {
     brands: { usdc },
     bootstrap: { storage },
@@ -310,8 +310,11 @@ test('updates status to OBSERVED on insufficient pool funds', async t => {
 
   t.deepEqual(
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
-    [{ evidence, status: PendingTxStatus.Observed }],
-    'OBSERVED status on insufficient pool funds',
+    [
+      { evidence, status: PendingTxStatus.Observed },
+      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+    ],
+    'ADVANCE_SKIPPED status on insufficient pool funds',
   );
 
   t.deepEqual(inspectLogs(), [
@@ -325,7 +328,7 @@ test('updates status to OBSERVED on insufficient pool funds', async t => {
   ]);
 });
 
-test('updates status to OBSERVED if makeChainAddress fails', async t => {
+test('updates status to ADVANCE_SKIPPED if makeChainAddress fails', async t => {
   const {
     bootstrap: { storage },
     extensions: {
@@ -340,8 +343,11 @@ test('updates status to OBSERVED if makeChainAddress fails', async t => {
 
   t.deepEqual(
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
-    [{ evidence, status: PendingTxStatus.Observed }],
-    'OBSERVED status on makeChainAddress failure',
+    [
+      { evidence, status: PendingTxStatus.Observed },
+      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+    ],
+    'ADVANCE_SKIPPED status on makeChainAddress failure',
   );
 
   t.deepEqual(inspectLogs(), [
@@ -547,8 +553,11 @@ test('updates status to OBSERVED if pre-condition checks fail', async t => {
 
   t.deepEqual(
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
-    [{ evidence, status: PendingTxStatus.Observed }],
-    'tx is recorded as OBSERVED',
+    [
+      { evidence, status: PendingTxStatus.Observed },
+      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+    ],
+    'tx is recorded as ADVANCE_SKIPPED',
   );
 
   t.deepEqual(inspectLogs(), [