fixup! feat(fast-usdc): skipAdvance when preconditions fail

Agoric · Feb 14, 2025 · 8d1e131 · 8d1e131
1 parent 1a632b7
commit 8d1e131
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/packages/fast-usdc/src/exos/advancer.js b/packages/fast-usdc/src/exos/advancer.js
@@ -217,7 +217,7 @@ export const prepareAdvancerKit = (
             });
           } catch (error) {
             log('Advancer error:', error);
-            statusManager.skipAdvance(evidence, ['PRECONDITIONS_FAILED']);
+            statusManager.skipAdvance(evidence, [error.message]);
           }
         },
         /** @param {ChainAddress} intermediateRecipient */

diff --git a/packages/fast-usdc/test/exos/advancer.test.ts b/packages/fast-usdc/test/exos/advancer.test.ts
@@ -312,7 +312,12 @@ test('updates status to ADVANCE_SKIPPED on insufficient pool funds', async t =>
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
     [
       { evidence, status: PendingTxStatus.Observed },
-      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+      {
+        risksIdentified: [
+          'Cannot borrow. Requested {"brand":"[Alleged: USDC brand]","value":"[293999999n]"} must be less than pool balance {"brand":"[Alleged: USDC brand]","value":"[1n]"}.',
+        ],
+        status: 'ADVANCE_SKIPPED',
+      },
     ],
     'ADVANCE_SKIPPED status on insufficient pool funds',
   );
@@ -345,7 +350,10 @@ test('updates status to ADVANCE_SKIPPED if makeChainAddress fails', async t => {
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
     [
       { evidence, status: PendingTxStatus.Observed },
-      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+      {
+        risksIdentified: ['Chain info not found for bech32Prefix "random"'],
+        status: 'ADVANCE_SKIPPED',
+      },
     ],
     'ADVANCE_SKIPPED status on makeChainAddress failure',
   );
@@ -555,7 +563,10 @@ test('updates status to ADVANCE_SKIPPED if pre-condition checks fail', async t =
     storage.getDeserialized(`fun.txns.${evidence.txHash}`),
     [
       { evidence, status: PendingTxStatus.Observed },
-      { risksIdentified: ['PRECONDITIONS_FAILED'], status: 'ADVANCE_SKIPPED' },
+      {
+        risksIdentified: ['query: {} - Must have missing properties ["EUD"]'],
+        status: 'ADVANCE_SKIPPED',
+      },
     ],
     'tx is recorded as ADVANCE_SKIPPED',
   );