Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant words in comment #10674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/SwingSet/docs/garbage-collection.md
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ The algorithm for comms is mostly simpler than the kernel because:
However it's slightly more complex because of the need to distinguish between informed and ignorant inbound messages, and the possibility that we choose to log or kill-connection when a `retireImport`/`retireExport` arrives after we know the race window has closed.


(TODO): describe the code which tracks REACHABLE/RECOGNIZABLE for all objects the the comms object table, the "reachable" flag in each c-list entry, the code that computes the overall reachability state, and the creation and processing of remote-side `dropImports`/etc messages.
(TODO): describe the code which tracks REACHABLE/RECOGNIZABLE for all objects the comms object table, the "reachable" flag in each c-list entry, the code that computes the overall reachability state, and the creation and processing of remote-side `dropImports`/etc messages.

## Races over the wire

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function makeNetstringReader({ fd, encoding }) {

const readMore = () => {
assert(!decoded.length);
// we could be smarter about read lengths (parse the the netstring
// we could be smarter about read lengths (parse the netstring
// header and do a blocking read of the entire payload), but the
// efficiency gain is not huge
const bytesRead = fs.readSync(fd, input); // blocking read
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ test('virtual object gc', async t => {
8,9 no n/a no no (retained unused)

Things 5, 6, and 7 are essentially the same as 4, but they are dropped by a
loop at the end, to make sure that that works.
loop at the end, to make sure that works.

Things 8 and 9 are both the same. They are never used and so are retained
where they were originally stashed on creation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ test.serial('stakeAtom', async t => {
// to fresh contract state on each iteration, and since this is a bootstrap test
// that means either restarting bootstrap or starting a new contract and
// restarting that one. For them to share bootstrap they'll each need a unique
// instance name, which will require paramatizing the the two builders scripts
// instance name, which will require paramatizing the two builders scripts
// and the two core-eval functions.
test.serial('basicFlows', async t => {
const {
Expand Down
2 changes: 1 addition & 1 deletion packages/fast-usdc/src/exos/operator-kit.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const prepareOperatorKit = (zone, staticPowers) =>
async SubmitEvidence(evidence) {
const { operator } = this.facets;
// TODO(bootstrap integration): cause this call to throw and confirm that it
// shows up in the the smart-wallet UpdateRecord `error` property
// shows up in the smart-wallet UpdateRecord `error` property
await operator.submitEvidence(evidence);
return staticPowers.makeInertInvitation(
'evidence was pushed in the invitation maker call',
Expand Down
2 changes: 1 addition & 1 deletion packages/smart-wallet/src/smartWallet.js
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ const namesOf = async (target, nameHub) => {
*
* @param {Issuer} issuer
* @param {Brand} brand
* @returns {Promise<boolean>} true iff the the brand and issuer match
* @returns {Promise<boolean>} true iff the brand and issuer match
*/
const checkMutual = (issuer, brand) =>
Promise.all([
Expand Down
2 changes: 1 addition & 1 deletion packages/swing-store/docs/transcriptstore.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Pruned spans are not available for export artifacts, of course, because the data

Every transcript span, both current and historic, gets an export-data record. The record name is different for the two types of spans.

Historical spans, which are "closed" and no longer growing, use a record name of `transcript.${vatID}.${startPos}.${endPos}`, where `startPos` is the delivery number of the first delivery included in the span and `endPos` is the the delivery number of the first delivery included in the **next** span (i.e., the former is an inclusive lower bound and the latter is an exclusive upper bound).
Historical spans, which are "closed" and no longer growing, use a record name of `transcript.${vatID}.${startPos}.${endPos}`, where `startPos` is the delivery number of the first delivery included in the span and `endPos` is the delivery number of the first delivery included in the **next** span (i.e., the former is an inclusive lower bound and the latter is an exclusive upper bound).
The value is a JSON-serialized record of `{ vatID, startPos, endPos, hash, isCurrent, incarnation }` (where `isCurrent = 0`).

The current span, if any, uses a record name of `transcript.${vatID}.current`, and has the same value as historical spans (except `isCurrent = 1`). Current spans are growing: new transcript items are added as more deliveries are made, until the span is closed off (becomes historical) and replaced with a new current span. There is at most one current span per vatID.
Expand Down