Add PSM upgrade for upgrade-19 #10730
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
fc30b3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://99cb57ec.agoric-sdk.pages.dev |
| Branch Preview URL: | https://iomekam-psm-upgrade.agoric-sdk.pages.dev |
|
The Upgrade Considerations section is a copy of the one from #10541. Please consider the differences and re-write. |
|
I see that you included the |
| @@ -0,0 +1,80 @@ | |||
| /* eslint-env node */ | |||
| /** | |||
| * @file The goal of this file is to make sure v36-reserve upgraded. | |||
| * 1. Simulate trade of IST and USDC | ||
| * 2. Upgrade all PSMs | ||
| * 3. Verify metrics are the same after the upgrade | ||
| * 4. Verity trading is still possible after the upgrade |
There was a problem hiding this comment.
typo
| * 4. Verity trading is still possible after the upgrade | |
| * 4. Verify trading is still possible after the upgrade |
| }; | ||
| }); | ||
|
|
||
| test.serial('similate trade of IST and USDC', async t => { |
There was a problem hiding this comment.
typo
| test.serial('similate trade of IST and USDC', async t => { | |
| test.serial('simulate trade of IST and USDC', async t => { |
| console.log('[CONTRACT_KITS]', contractKits); | ||
| console.log('[ISSUER]', usdcIssuer); |
There was a problem hiding this comment.
Why print the square brackets?
a3p-integration/proposals/p:upgrade-19/swapAnchorForMintedSeat/swap-anchor-for-minted-seat.js
Show resolved
Hide resolved
| console.log(await E(seat).getPayouts()); | ||
| console.log('Done.'); |
There was a problem hiding this comment.
please add a comment here that the success will be checked in the test by reading from vstorage.
| t.is(metrics.anchorPoolBalance.value, 500000n); | ||
| t.is(metrics.feePoolBalance.value, 0n); | ||
| t.is(metrics.mintedPoolBalance.value, 500000n); | ||
| t.is(metrics.totalAnchorProvided.value, 0n); | ||
| t.is(metrics.totalMintedProvided.value, 500000n); |
There was a problem hiding this comment.
I find it hard to compare these values visually with the previous and following values. What I've done in the past is use a variable to hold the mutating value, so the comparison always looks the same, and the changes appear explicitly near the place that changes the value.
In vaultFactoryTest, totalCollateral holds the evolving value, and it can be inserted in many different assertions
await m.assertChange({
totalCollateral: { value: totalCollateral },
});
When it changes, there's an explicit assignment.
With 5 values changing in sync here, I'd define a record
const poolMetrics = {
anchorBalance: 500_000n,
feeBalance: 0n
mintedBalance: 500_000n,
anchorProvided: 0n,
mintedProvided: 500_000n,
};
and a comparer compareLevels(metrics, poolMetrics);. Then we could see that there's only one place where we change the values of poolMetrics
poolMetrics.anchorBalance = poolMetrics.anchorBalance + 500_000n;
poolMetrics.mintedBalance = poolMetrics.mintedBalance + 500_000n;
poolMetrics.mintedProvided = poolMetrics.mintedProvided + 500_000n;
and otherwise, the values must be the same.
This particular case is on the very low end of the range where that would be called for, since the values only change once, but they're tested three times and there are 5 separate values compared, so I would probably make the change, but I'll leave it up to your judgement as to whether it's actually useful. This approach is most useful when the tests and outcomes keep changing, and this particular case might be stable already.
…mekam-psm-upgrade
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
closes: #10403
Description
Adds the upgrade of the psm contracts to upgrade 19. To ensure that this upgrade will succeed, we've also added test coverage in A3P.
Upgrade Considerations
This PR adds the PSM contract to the list of vat upgrades. The PSM upgrade proposal will upgrade all PSM instances on the chain. We've added A3P tests to ensure that the upgrade is successful and that assets are still in the reserve after the upgrade.