feat: Run monitoring follower with acceptance testing #10816
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
4cc34b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6f75c18b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://usman-acceptance-pre-test.agoric-sdk.pages.dev |
| start_follower | ||
| } | ||
|
|
||
| run_command_inside_container() { |
There was a problem hiding this comment.
I don't understand why we're running the loadgen follower in an a3p container, or in a container at all. Why not run it on the host directly? Are we trying to not affect the host environment for some reason?
My biggest worry is that I want us to ultimately support running the follower with some modifications, e.g. the random init memory option for xsnap. All that will likely require rebuilding the SDK, which should not happen in a "light production" container (which unfortunately the agoric container isn't right now)
There was a problem hiding this comment.
I thought we decided we would run a container from the a3p image? Isn't that the case? I don't have any other reason to run the follower in a container
There was a problem hiding this comment.
Moved to the host (outside of container)
| ################################################################################## | ||
| # Hacky way to get go lang in the container # | ||
| ################################################################################## | ||
| install_go() { |
There was a problem hiding this comment.
If we're using an agoric-sdk container, why do we even need to rebuild the SDK right now?
There was a problem hiding this comment.
I will remove this before marking the PR ready. This was just for testing.
| fi | ||
|
|
||
| exit_message="$(node "$DIRECTORY_PATH/wait-for-follower.mjs" "^exit code \d+$")" | ||
| echo "follower test result: $exit_message" |
There was a problem hiding this comment.
If the exit code isn't 0, this should fail
There was a problem hiding this comment.
Wasn't aware that we want to fail the pipeline on this failure. Will do
The runner output can be seen in the artifacts of this run: |
closes: #XXXX
refs: #XXXX
Description
This PR runs a loadgen follower in the accpetance proposal pre test hook and monitor the chain while the acceptance proposal is executing
The generated artifacts are also uploaded to Github
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
None
Upgrade Considerations
None