chore(acceptance): upgrade pp's governor #10817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
requested changes
Jan 8, 2025
Jorge-Lopes
reviewed
Jan 9, 2025
| for await (const vatName of Object.keys(vats)) { | ||
| actual[vatName] = await getVatDetails(vatName); | ||
| } | ||
| t.like(actual, vats); |
There was a problem hiding this comment.
Is it safe to assume that, at the moment that this test is executed, the incarnation of provisionPool and provisionPool-governor is always 0?
There was a problem hiding this comment.
Yeah, it might be worth setting the incarnation values in vats from test.before, and asserting that they have increased by one.
There was a problem hiding this comment.
resolved in 5d68e48
Deploying agoric-sdk with
|
| Latest commit: |
8c6668f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2761b5c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://anil-10411-gov-upgrade.agoric-sdk.pages.dev |
anilhelvaci
force-pushed
the
anil/10411-gov-upgrade
branch
from
9c4067a to
5d68e48
Compare
Jorge-Lopes
approved these changes
Jan 13, 2025
Chris-Hibbert
approved these changes
Jan 13, 2025
refs: #10411 fix: forgot to include `null upgrade` fix into the previous commit
anilhelvaci
force-pushed
the
anil/10411-gov-upgrade
branch
from
5d68e48 to
8c6668f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10411
Description
According to #10411 we need to showcase we can upgrade contractGovernor for a governed contract. This PR chooses
provisionPoolas it's example governed contract because;Security Considerations
No security considerations.
Scaling Considerations
As long as CI passes, scaling shouldn't be a problem.
Documentation Considerations
None.
Testing Considerations
CI with integration tests should pass.
Upgrade Considerations
This PR concerns upgrading provisionPool's governor itself.