test of replacing fast-usdc operators #10834

turadg · 2025-01-11T01:21:53Z

closes: #10754

Description

Adds a test for adding new operators after removing

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages · 2025-01-11T01:21:55Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`da7c727`
Status:	✅ Deploy successful!
Preview URL:	https://18525661.agoric-sdk.pages.dev
Branch Preview URL:	https://10754-replace-operators.agoric-sdk.pages.dev

View logs

dckc

The tests show that this does what we need.

The @type {CoreEvalBuilder} vs. @satisfies {CoreEvalBuilder} is hiding quite a few type errors. I expect you'll want to clean that up, but I'm OK with postponing it indefinitely.

dckc · 2025-01-13T23:11:55Z

a3p-integration/proposals/f:fast-usdc/operators.test.js

+
+  {
+    // no invitation before
+    const curr = await vstorageKit.readPublished(addr);


The name addr threw me off; I assumed it started with agoric1... and did a double-take when I got to here.

not critical.

dckc · 2025-01-13T23:16:24Z

packages/builders/scripts/fast-usdc/add-operators.build.js

+  await writeCoreEval('add-operators', utils =>
+    defaultProposalBuilder(utils, config),
+  );
+};


80 lines of almost completely boilerplate code. This gets boring.

The platform is fixed. The platform is fixed. The platform is fixed...

yeah, I felt like I was fighting the APIs a bit here. another day.

dckc · 2025-01-13T23:17:45Z

packages/fast-usdc/src/add-operators.core.js

+const trace = makeTracer('FUSD-AddOperators', true);
+
+/** @type {TypedPattern<FastUSDCConfig>} */
+export const FastUSDCConfigShape = M.splitRecord({


Is this duplicated? Should it move to ./type-guards.js?

dckc · 2025-01-13T23:18:31Z

packages/fast-usdc/src/add-operators.core.js

+ *   instance: PromiseSpaceOf<{ fastUsdc: Instance<FastUsdcSF> }>;
+ *   issuer: PromiseSpaceOf<{ FastLP: Issuer }>;
+ *   brand: PromiseSpaceOf<{ FastLP: Brand }>;
+ * }} FastUSDCCorePowers


FastUSDCCorePowers looks familiar too. move to types.js?

dckc · 2025-01-13T23:20:58Z

packages/builders/scripts/fast-usdc/add-operators.build.js

+  USDC: Far('USDC Brand'),
+});
+
+/** @type {CoreEvalBuilder} */


Suggested change

/** @type {CoreEvalBuilder} */

/** @satisfies {CoreEvalBuilder} */

Using @type hides type errors around config.

Maybe not critical, but probably worth fixing.

dckc · 2025-01-13T23:22:39Z

packages/builders/scripts/fast-usdc/add-operators.build.js

+    getManifestCall: [
+      getManifestForAddOperators.name,
+      {
+        options: toExternalConfig(config, crossVatContext),


You could skip toExternalConfig since this is JSON-happy data.

understood. I try to keep the differences to line deletion as much as possible, for easier reconciliation

dckc · 2025-01-13T23:23:04Z

packages/builders/scripts/fast-usdc/add-operators.build.js

+/** @type {CoreEvalBuilder} */
+export const defaultProposalBuilder = async (
+  powers,
+  /** @type {FastUSDCConfig} */ config,


Suggested change

/** @type {FastUSDCConfig} */ config,

/** @type {{ oracles: Record<string, string> }} */ config,

dckc · 2025-01-13T23:24:17Z

packages/fast-usdc/src/add-operators.core.js

+ *   restoreRef: (b: ERef<ManifestBundleRef>) => Promise<Installation>;
+ * }} utils
+ * @param {{
+ *   options: LegibleCapData<FastUSDCConfig>;


The builder isn't providing a whole FastUSDCConfig.

See @satisfies vs @type earlier.

dckc · 2025-01-13T23:24:51Z

packages/fast-usdc/src/add-operators.core.js

+          // widely shared: name services
+          agoricNames: true,
+          namesByAddress: true,
+          board: true,


board doesn't seem to be used.

dckc · 2025-01-13T23:28:34Z

packages/fast-usdc/src/utils/core-eval.js

+      const toWatch = await E(creatorFacet).makeOperatorInvitation(address);
+
+      const amt = await E(depositFacet).receive(toWatch);
+      trace('sent', amt, 'to', name);


The exo's use a default arg for trace. The idea appeals to me here to let the caller keep one trace sequence. not sure how worthwhile it is.

mergify · 2025-01-14T01:26:45Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

dckc · 2025-01-14T03:32:22Z

packages/builders/scripts/fast-usdc/init-fast-usdc.js

-    sourceSpec: '@agoric/fast-usdc/src/fast-usdc.start.js',
+    sourceSpec: '@agoric/fast-usdc/src/start-fast-usdc.core.js',


I didn't notice renaming before the extension until now...

I quite like having fast-usdc.contract.js and the core-eval code to start it next to each other. So I'd prefer fast-usd-start.core.js.

OTOH, I hope that in due course, we mostly avoid custom code for starting contracts. So I can live with whatever.

Thanks for the flexibility. Let's devise together some consistent naming pattern and then apply it across the codebase. It's a non-breaking change

mergify · 2025-01-14T19:20:33Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ integration-test-result
☑️ linear-history

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

turadg mentioned this pull request Jan 11, 2025

ability to replace oracle operators in fast-usdc #10755

Merged

turadg force-pushed the 10754-replace-operators branch from a0c26df to 81558ca Compare January 13, 2025 23:08

turadg requested a review from dckc January 13, 2025 23:09

turadg marked this pull request as ready for review January 13, 2025 23:09

turadg requested a review from a team as a code owner January 13, 2025 23:09

turadg requested a review from samsiegart January 13, 2025 23:29

dckc approved these changes Jan 13, 2025

View reviewed changes

turadg added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Jan 13, 2025

turadg force-pushed the 10754-replace-operators branch from 81558ca to d84d27e Compare January 14, 2025 00:22

turadg added the automerge:rebase Automatically rebase updates, then merge label Jan 14, 2025

turadg added force:integration Force integration tests to run on PR and removed automerge:rebase Automatically rebase updates, then merge labels Jan 14, 2025

dckc reviewed Jan 14, 2025

View reviewed changes

turadg added 8 commits January 14, 2025 10:25

refactor: rename .start.js to .core.js

0a4179b

refactor: name start-fast-usdc.build.js

b73f699

refactor: extract publishFeedPolicy

71f7add

refactor: extract inviteOracles

8295bed

refactor: extract FastUSDCConfigShape

9e3edbf

chore(types): satisfies CoreEvalBuilder

92c9645

test: print wallets

7191f0b

test: add operators

da7c727

turadg force-pushed the 10754-replace-operators branch from 86cc97d to da7c727 Compare January 14, 2025 18:26

turadg added the automerge:rebase Automatically rebase updates, then merge label Jan 14, 2025

mergify bot merged commit 7e9048c into master Jan 14, 2025
85 checks passed

mergify bot deleted the 10754-replace-operators branch January 14, 2025 20:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test of replacing fast-usdc operators #10834

test of replacing fast-usdc operators #10834

turadg commented Jan 11, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 11, 2025 •

edited

Loading

dckc left a comment

dckc Jan 13, 2025

dckc Jan 13, 2025

turadg Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

turadg Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

dckc Jan 13, 2025

mergify bot commented Jan 14, 2025

dckc Jan 14, 2025

turadg Jan 14, 2025

mergify bot commented Jan 14, 2025

	/** @type {CoreEvalBuilder} */
	/** @satisfies {CoreEvalBuilder} */

	/** @type {FastUSDCConfig} */ config,
	/** @type {{ oracles: Record<string, string> }} */ config,

		sourceSpec: '@agoric/fast-usdc/src/fast-usdc.start.js',
		sourceSpec: '@agoric/fast-usdc/src/start-fast-usdc.core.js',

test of replacing fast-usdc operators #10834

test of replacing fast-usdc operators #10834

Conversation

turadg commented Jan 11, 2025 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Jan 11, 2025 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Jan 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Jan 14, 2025

turadg commented Jan 11, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 11, 2025 •

edited

Loading