segregate test files in a3p proposals #10853
Draft
+859
−562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
dcfcb0b
|
| Status: | 🚫 Deploy failed. |
turadg
force-pushed
the
115-a3p-tests
branch
2 times, most recently
from
ea695b6 to
d6940ba
Compare
To override 8.x in synthetic-chain that seems to be incompatible with SES: #51 20.98 TypeError#1: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, [object Object] #51 20.98 at InertConstructor.defineProperty (<anonymous>) #51 20.98 at changeToString (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:57:9) #51 20.98 at mimicFunction (file:///usr/src/proposals/n:upgrade-next/node_modules/mimic-fn/index.js:68:2) #51 20.98 at onetime (file:///usr/src/proposals/n:upgrade-next/node_modules/onetime/index.js:27:2) #51 20.98 at execa (file:///usr/src/proposals/n:upgrade-next/node_modules/@agoric/synthetic-chain/node_modules/execa/index.js:160:28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-3-proposals#115
Description
A3P is getting this feature,
This PR takes advantage of it for a3p-integration tests.
Draft until it uses a new release of
@agoric/synthetic-chain. Meanwhile the test refactoring should pass with the existing version.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations