chore: fusdc optional maxVariable in FeeConfig
#10859
Open
+13
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fb901e0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f111d2f.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10858-max-variable-fee-confi.agoric-sdk.pages.dev |
turadg
reviewed
Jan 17, 2025
packages/fast-usdc/src/types.ts
Outdated
| maxVariable: Amount<'nat'>; | ||
| /** a cap on variable fees. no cap if undefined */ | ||
| maxVariable?: Amount<'nat'>; | ||
| /** percent of fees that go to contract (remaining goes to LPs) */ |
There was a problem hiding this comment.
proportion of fees ("percent" is a particular notation)
packages/fast-usdc/src/types.ts
Outdated
| flat: Amount<'nat'>; | ||
| /** percentage charged for every advance */ |
There was a problem hiding this comment.
thanks for these explanations. please be a bit more explicit.
Suggested change
| /** percentage charged for every advance */ | |
| /** proportion of advance kept as a fee */ |
packages/fast-usdc/src/types.ts
Outdated
| variableRate: Ratio; | ||
| maxVariable: Amount<'nat'>; | ||
| /** a cap on variable fees. no cap if undefined */ |
There was a problem hiding this comment.
I read this at first as a limit on how the variableRate could move. Now I understand it as a max on the variable component of the total fee.
Why have a max on that component instead of the fee overall? They're functionally equivalent offset by flat, but having a maxFee is much clearer to the user.
0xpatrickdev
force-pushed
the
10858/max-variable-fee-config
branch
from
10aa465 to
fb901e0
Compare
turadg
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10858
Description
If
maxVariableisundefinedinFeeConfig, do not cap fees.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Adds new unit test.
Upgrade Considerations
None, part of initial release for FUSDC.