Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove DD unit tests metrics reporting from CI #10930

Merged
merged 1 commit into from
Feb 18, 2025
+0 −211
Merged

ci: remove DD unit tests metrics reporting from CI #10930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/actions/post-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ inputs:
description: 'token for datadog'
required: false
default: ''
datadog-site:
description: 'site for datadog'
required: false
default: 'us3.datadoghq.com'
gcp-credentials:
description: 'gcp'
required: false
Expand All @@ -22,23 +18,6 @@ inputs:
runs:
using: composite
steps:
- name: upload tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mujahidkay Won't it stop reporting of integration and benchmarking too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is used to collect info from individual packages' unit tests via collect-testruns.sh which further converts ava output to a junit format. And each package's junit xml is then exported to DD via

timeout 30 npx @datadog/datadog-ci junit upload --service agoric-sdk ./packages/*/junit.xml

I don't understand why this needs to be done in test-docker-build step. The info is already being sent when we run test-all-packages. On the other hand, benchmarking uses a completely different action which I have kept as is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, would appreciate a second set of eyes on this. Maybe @usmanmani1122 👀

shell: bash
if: ${{ github.repository_owner == 'agoric' }} && (success() || failure())
env:
DD_ENV: ci
DATADOG_SITE: ${{ inputs.datadog-site }}
continue-on-error: true
run: |
./scripts/ci/collect-testruns.sh
if [ "${{ inputs.datadog-token }}" != "" ]; then
export DATADOG_API_KEY="${{ inputs.datadog-token }}"
export DD_ENV="ci"
export DD_SITE="${{ inputs.datadog-site }}"

npx @datadog/datadog-ci --version
timeout 30 npx @datadog/datadog-ci junit upload --service agoric-sdk ./packages/*/junit.xml
fi
- name: upload coverage prepare
shell: bash
id: coverage-prep
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/test-all-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -341,7 +340,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -385,7 +383,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -427,7 +424,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -472,7 +468,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -514,7 +509,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -560,7 +554,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -612,7 +605,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -656,7 +648,6 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}

Expand Down Expand Up @@ -699,6 +690,5 @@ jobs:
continue-on-error: true
timeout-minutes: 4
with:
datadog-token: ${{ secrets.DATADOG_API_KEY }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
gcp-credentials: ${{ secrets.GCP_CREDENTIALS }}
154 changes: 0 additions & 154 deletions scripts/ava-etap-to-junit.mjs
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions scripts/ci/collect-testruns.sh
View file
Open in desktop

This file was deleted.

Loading