-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added nix flake #10934
feat: added nix flake #10934
Conversation
Deploying agoric-sdk with
|
Latest commit: |
a33cd79
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4a02b0cb.agoric-sdk.pages.dev |
Branch Preview URL: | https://jeancarlobarrios-adding-flak.agoric-sdk.pages.dev |
What's the state of this? Was about to write my own flake when I saw this |
Im working on this as we speak, we can have a quick call if you want. I could actually use a couple pointers on this. |
that'd be nice! https://30.meet.cor.systems |
@@ -0,0 +1,36 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this flake depend on configuration from your system wide flake? Because when I try to build it I get the following error.
nix build
error: flake 'git+file:///Users/touseefliaqat/code/agoric-sdk' does not provide attribute 'packages.aarch64-darwin.default' or 'defaultPackage.aarch64-darwin'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm it should not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should not, how did you installed nix? make sure flakes are enable to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh oh, actually here you only need to run nix develop not nix build, I have only define a devshell I have not define a build shell yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember how i installed nix.
how to check if it has flakes enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in your nix config file generally: ~/.config/nix/nix.conf
ensure this configuration is set: experimental-features = nix-command flakes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toliaqat lmk if it worked for you, remember to just run nix develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, based on whether @toliaqat removes his request for changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad there's CI for this feature! That should prevent accidental breakage.
Lmk if this flake is good enough for your use case |
lmk if this flake is good enough to start and it works for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite winning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need distutils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
The PR was reviewed, tested for viability, and approved by @dckc. Since @toliaqat is on vacation, I'm dismissing this review so that we can merge it.
@toliaqat, please contact @JeancarloBarrios if you have further questions.
Co-authored-by: Dan Connolly <[email protected]>
49f56c7
to
a33cd79
Compare
Adding a Nix flake for a deterministic development environment.
This currently provides only a development shell. To use it, ensure you have Nix installed with experimental features enabled and the nix command available. Then, run
nix develop
to enter a shell with all OS dependencies needed for development.Future improvements may include automating build steps as well.
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations