shrink Fast USDC core eval bundle #11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
e41132d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab432a4b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-fast-usdc-bloat.agoric-sdk.pages.dev |
dckc
approved these changes
Feb 13, 2025
turadg
force-pushed
the
ta/fast-usdc-bloat
branch
from
6d1b9de to
e41132d
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
https://ping.pub/agoric/gov/87 had a surprisingly large core-eval bundle: https://github.com/Agoric/agoric-sdk/releases/tag/fast-usdc-beta-1
The reason was that it imported typeguards from the barrel export of
@agoric/orchestration, which entrained@agoric/cosmic-proto. All it really needed wastypeGuards.jsso this imports that module by deep import.Eventually we'll want an
"exports"map for the package but that's out of scope.Security Considerations
n/a
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
cd a3p-integration/proposals/b:beta-fast-usdc ../../scripts/build-submission.sh fast-usdc/start-fast-usdc.build.js submission --net A3P_INTEGRATION --noNoblemaster
total size: 1636325
PR
total size: 586271
(64% reduction)
Upgrade Considerations
none