fix(a3p-integration): replaceFeeDistributor flakiness fix

[anilhelvaci]

closes: #10998

Description

In #10998, we see a flake introduced after a3p-integration/p:upgrade-19 tests migrated to a3p-integration/n:upgrade-next. The investigations showed that feeDistributor was collecting more fees than our test is producing.

Passing

2025-02-11T22:51:00.145Z SwingSet: vat: v36: ----- ReserveKit.5  9 received collateral { brand: Object [Alleged: IST brand] {}, value: 500_000n }

Failing

2025-02-11T22:04:40.861Z SwingSet: vat: v36: ----- ReserveKit.5  8 received collateral { brand: Object [Alleged: IST brand] {}, value: 550_000n }

My argument is, priorly we were introducing the new feeDistributor dedicated to testing during our test initiation phase. And after introduction of the feeDistributor, we were waiting for one full collectionInterval to clear any leftover fees that haven't been collected by the old feeDistributor. And only then we start producing new fees. I confirmed that this is not the current behavior after the n:upgrade-next migration as of the commit 271c55f#diff-7dd0ed44de879823d10b252f6483f52174e4fb9240966e7fcd1754298b41b0d7L161

  await evalBundles(coreEvalDir);
  // Wait for a round to give the new feeDistributor time to clear out outstanding fees, if any.
  await sleep(collectionInterval + 5000, { log: console.log, setTimeout });

As of the migration to upgrade-19, we introduce the new feeDistributor in uprage.go which causes fees produced by other tests to get in the way of replaceFeeDistributor.test.js in a flakey way since the collectionInterval is 30 seconds.

Solution

Just switch from AmountMath.isEqual to AmountMath.isGTE when polling for results.

Testing Considerations

Make sure integration tests pass in a consistent way.

Upgrade Considerations

Get rid of the flake so upgrade-19 shipment isn't blocked.

[anilhelvaci]

CI fails in multichain tests:

• https://github.com/Agoric/agoric-sdk/actions/runs/13326568486/job/37223463516?pr=11006#step:14:219
• https://github.com/Agoric/agoric-sdk/actions/runs/13326568486/job/37223463179?pr=11006#step:14:397

I haven't been able to find anything related to feeDistributor in the logs. You mentioned multichain test failures yesterday as well. Are these the same as the ones you saw? @turadg

[turadg]

CI fails in multichain tests:

Independent flake,

• fix flake in multichain-testing #9934

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	58de927
Status:	✅  Deploy successful!
Preview URL:	https://18c2298d.agoric-sdk.pages.dev
Branch Preview URL:	https://anil-10988-flakey-fee-distri.agoric-sdk.pages.dev

View logs