Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(PSM!): make PSM use zcf.atomicRearrange() #7903

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

Chris-Hibbert
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert commented Jun 8, 2023

closes: #6678
refs: #7900

Description

update PSM to use zcf.atomicRearrange().

This change must not be pushed to the chain before #7900.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

None

Release considerations

This requires a change to Zoe (#7900). Since PSM gets upgraded separately from Zoe, this is staged as a separate PR. Once #7900 is on chain, this update can be made, even if it's in the same release cycle, as long as Zoe is upgraded first. This change is independent of changes to other contracts.

@Chris-Hibbert Chris-Hibbert added Zoe package: Zoe Inter-protocol Overarching Inter Protocol contract-upgrade labels Jun 8, 2023
@Chris-Hibbert Chris-Hibbert self-assigned this Jun 8, 2023
@Chris-Hibbert Chris-Hibbert marked this pull request as draft June 8, 2023 23:25
@Chris-Hibbert Chris-Hibbert force-pushed the 6678-intrinsicAtomicTransfer branch from b8f88d7 to 14ac202 Compare June 22, 2023 16:37
@Chris-Hibbert Chris-Hibbert force-pushed the 6678-intrinsicAtomicTransfer branch from a7a4fed to a16493d Compare June 23, 2023 23:33
@Chris-Hibbert Chris-Hibbert force-pushed the 6678-intrinsicAtomicTransfer branch from a16493d to b9c3ff2 Compare July 17, 2023 23:07
Base automatically changed from 6678-intrinsicAtomicTransfer to master July 27, 2023 19:37
Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: e245d6a
Status: ✅  Deploy successful!
Preview URL: https://5d33edad.agoric-sdk.pages.dev
Branch Preview URL: https://6678-atomicpsm.agoric-sdk.pages.dev

View logs

@Chris-Hibbert Chris-Hibbert requested a review from turadg August 22, 2024 23:37
@Chris-Hibbert Chris-Hibbert marked this pull request as ready for review November 7, 2024 00:22
@Chris-Hibbert Chris-Hibbert requested a review from a team as a code owner November 7, 2024 00:22
@Chris-Hibbert Chris-Hibbert requested a review from thams November 7, 2024 00:22
@Chris-Hibbert
Copy link
Contributor Author

see also #10403, which provides a reason for merging this.

@Chris-Hibbert Chris-Hibbert added the automerge:rebase Automatically rebase updates, then merge label Nov 7, 2024
@mergify mergify bot merged commit ed76c8b into master Nov 7, 2024
81 checks passed
@mergify mergify bot deleted the 6678-atomicPSM branch November 7, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge contract-upgrade Inter-protocol Overarching Inter Protocol Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove reallocate from ZCF
2 participants