-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: indexing locally and running tests #41
Conversation
README.md
Outdated
docker logs <container_id> | ||
``` | ||
|
||
Replace <container_id> with the actual ID of your Docker container involved in indexing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead name the container which we are talking about? I think it is hardcoded explicitly in docker compose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be we can add the command here to get container Id from container name:
docker inspect --format="{{.Id}}" container_name
And I think container name is subquery-node
in our case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me verify locally and then update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Start up an A3P instance | ||
|
||
```sh | ||
docker run -p 26657:26657 -p 1317:1317 -p 9090:9090 ghcr.io/agoric/agoric-3-proposals:latest | ||
``` | ||
```sh | ||
docker run -p 26657:26657 -p 1317:1317 -p 9090:9090 ghcr.io/agoric/agoric-3-proposals:latest | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration is specifically for the ci profile within the a3p container. The reason for using the ci profile is because the URL http://host.docker.internal:26657
is not accessible in CI environments. Therefore, I included the a3p service in the Docker Compose file and assigned it a ci profile to ensure it only runs in CI. In the CI environment, we then use the address http://agd:26657
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why ci
was necessary. Your comment here is helpful. Please include it somewhere in the README or source code.
e887e78
to
195a448
Compare
195a448
to
0a174c0
Compare
- Check the logs of indexer for any errors or warnings that might indicate what is wrong. Use the command: | ||
|
||
```sh | ||
docker logs -f agoric-subql-subquery-node-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this container name remain consistent on each compse up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was just curious about the repo name prefix and *-1 postfix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the name remains consistent. Same locally as well as CI.
The PR updates the README. Mainly the sections related to running the indexer locally and how tests work in this repo.