Unify flows and orca
#15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
requested changes
Aug 14, 2024
| t.log({ | ||
| VatData | ||
| }) | ||
| const setupContext = await commonSetup(t); |
There was a problem hiding this comment.
👏 glad to see this being used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The idea of using predefined
*.flows.jsfiles fromorchestrationpackage in third party contracts is a work in progress.Problem Solved
The current way
orcacontract demonstratesorchestrationpackage is different to the flows approach described above. Here we take the first of step for unifying those approaches under one repository to have better teaching material fororchestrationAPI.What are some of the improvements
flowsbrings andorcacan use?basic-flows.contract.jsis bundled and deployed from the host machine usingagoric runbasic-flows.contract.test.jsusescommonSetupfrom the orchestration test environment to have simpler and more generic testing setupTesting
I have confirmed that test pass and contracts can be deployed to multichain setup for both
orcaandflows.What can be better?
Currently the folder structure is a little bit too nested. We should flatten that
cc @Jovonni