Fix/offer handler test not resolving vow from async-flow

[Jovonni]

Fixes #20 , good catch @dckc 🚀

[Jovonni]

CI fails from:

➤ YN0028: +
➤ YN0028: -    "@agoric/zone": "npm:^0.2.2"
➤ YN0028: +    "@agoric/zone": "npm:dev"
➤ YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.
➤ YN0000: └ Completed
➤ YN0000: · Failed with errors in 27s 944ms

@agoric/zone package version was updated due to makeHeapVow not being exported on the previous version used.

How do we allow this change here?

[turadg]

Changes LGTM. Before merging please squash the fixup commit. (E.g. git rebase --interactive --autosquash)

Note that #20's title is "contract test to act like UI client". This fixes the one problem described in the issue body but I'm not certain it satisfies the title well enough to close that issue. You know this app much better than I so I leave that to you to decide.

[dckc]

There's a 3rd getOfferResult call that should also get the vt.when(...) treatment.

[dckc]

localchain doesn't have a getChainHub method, does it?

[dckc]

The value here should be a brand, not a string, right?

Why use a custom namehub implementation? boot-tools.js sets up agoricNames and agoricNamesAdmin in the boostratp promise space.

[Jovonni]

seeing this when I try to using agoricNames from boot-tools as you mention here:

orca-contract › orchestrate - osmosis makeAccount and fund returns a ContinuingOfferResult
  Rejected promise returned by test. Reason:

  Error {
    message: 'chain not found:agoric',
  }

  › makeError (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:349:61)
  › eval (.../async-flow/src/convert.js:100:1)
  › innerConvert (.../async-flow/src/convert.js:57:8)
  › convertRecur (.../async-flow/src/convert.js:26:8)
  › Alleged: replayMembrane.convert [as guestToHost] (.../async-flow/src/convert.js:76:1)
  › eval (.../async-flow/src/async-flow.js:265:37)

and

Error#1: "nameKey" not found: "chain"
    at makeError (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:349:61)
    at Function.fail (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/ses/src/error/assert.js:481:20)
    at NonNullish (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@agoric/internal/src/errors.js:14:10)
    at Object.lookup (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@agoric/vats/src/nameHub.js:177:15)
    at In "lookup" method of (NameHubKit nameHub) [as lookup] (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/exo/src/exo-tools.js:171:24)
    at localApplyMethod (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/local.js:126:18)
    at Object.applyMethod (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:455:16)
    at dispatchToHandler (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:156:22)
    at doDispatch (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:486:7)
    at win (file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:505:26)
    at file:///Users/jovonni/Documents/projects/dapp-orchestration-basics/node_modules/@endo/eventual-send/src/handled-promise.js:523:20

digging

[turadg]

Will review when CI is green