-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: start orca contract with core-eval #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for @agoric/X, use @dev - for @endo/X etc., check `yarn why` in agoric-sdk
- avoid import from @agoric/internal
to avoid bringing in all of ERTP bundle size before: 905582; after: 709624 (Sum of file sizes)
Jovonni
added a commit
that referenced
this pull request
Jun 25, 2024
…ploys, integtrating #4 tests now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into helping with #3 . Reproducing those results seems to involve the whole multichain thing, but the error doesn't seem to have anything to do with interactions with other chains. I'd like to get this sort of thing working cleanly in ava tests, where we can use tools like a debugger.
For dependencies (not devDependencies), I started from scratch:
@agoric/XYZ
, I used dev versions:yarn add @agoric/XYZ@dev
@endo/XYZ
etc., I usedyarn why
inagoric-sdk
to see what version to use@agoric/internal
, I copieddebug.js
formakeTracer
and copied the 1-line definition ofStorageNodeShape
console.log()
totrace()
prepareRecorderKitMakers
in order to avoid bundling all of@agoric/ertp
Each time I touched a file, format-on-save invoked prettier. Those edits are in separate
style:
commits.DRAFT until:
When working on dapp-agoric-basics and dapp-offer-up, starting the chain takes just a few seconds. I'd like to know how to do that for the part of the multi-chain setup just for an agoric chain.