Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto-update ADDR in Makefile #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amessbee
Copy link
Contributor

This is same as #40 that was mistakenly merged to multichain-u17-with-icq instead of main.

@amessbee amessbee requested review from Jovonni and dckc September 27, 2024 08:05
# ADDR=agoric1k78s7qz7rxy8afyjrqk3dntg8m83zaw3upe60p
ADDR=agoric125d8s0tamx50gpqdd3m7f5gtkzkcnjs0ehsujr

# fetch the address of the deployer account from the chain - you may need to adjust this to match your setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we need to adjust this?
Isn't the point of this pr to take care of that?

)

$(info USERNAME is $(USERNAME))
$(info ADDR is $(ADDR))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update (remove) the corresponding instructions in the README

@amessbee amessbee requested a review from dckc September 28, 2024 02:36
@dckc
Copy link
Member

dckc commented Sep 28, 2024

What problem is this supposed to address?

Is there some reason why we don't use a fixed address (from a fixed mnemonic) for user1? That's what we do when setting up the keyring in agoric-3-proposals and in getting started for dapp-offer-up and such:

WARNING
Remember, this is just a demo. In real-world scenarios ensuring proper security around mnemonic phrases is critical!
To import your wallet, you'll need to copy the following mnemonic phrase into Keplr.

spike siege world rather ordinary upper napkin voice brush oppose junior route trim crush expire angry seminar anchor panther piano image pepper chest alone

@amessbee
Copy link
Contributor Author

I am not privy to the design decision to not use a fixed address, but current snippet saves me about ten seconds (calling the make add-address and copying the resulting address here).

If we go for a fixed address, this will become irrelevant. If there is an issue, I can add a task there to remove/update this code with the fixed address when we close that.

What problem is this supposed to address?

Is there some reason why we don't use a fixed address (from a fixed mnemonic) for user1? That's what we do when setting up the keyring in agoric-3-proposals and in getting started for dapp-offer-up and such:

WARNING
Remember, this is just a demo. In real-world scenarios ensuring proper security around mnemonic phrases is critical!
To import your wallet, you'll need to copy the following mnemonic phrase into Keplr.

spike siege world rather ordinary upper napkin voice brush oppose junior route trim crush expire angry seminar anchor panther piano image pepper chest alone

@amessbee
Copy link
Contributor Author

amessbee commented Oct 2, 2024

@Jovonni I have successfully deployed contract with the using this PR with updated ADDR and I am able to create an account in UI. So, this is tested with deployment.
I do, however, see the following error while doing make e2e for some reason. I suspect they are not related to my PR:

(Error#1)
Error#1: bundle orca was for /agoric/dapp-orchestration-basics/contract/src/orca.proposal.js , not /agoric/dapp-orchestration-basics/contract/src/orca.contract.js

  at async Object.installBundlesE2E (file:///agoric/dapp-orchestration-basics/contract/tools/e2e-tools.js:536:22)
  at async main (file:///agoric/dapp-orchestration-basics/contract/scripts/deploy-contract.js:126:5)

bundles add: orca from /agoric/dapp-orchestration-basics/contract/src/orca.contract.js
bundles bundled 280 files in bundle-orca.js at 2024-10-02T05:45:33.688Z with transforms with format endoZipBase64 and conditions []
(Error#2)
Error#2: bundle orca was for /agoric/dapp-orchestration-basics/contract/src/orca.contract.js , not /agoric/dapp-orchestration-basics/contract/src/orca.proposal.js

  at async Object.installBundlesE2E (file:///agoric/dapp-orchestration-basics/contract/tools/e2e-tools.js:537:31)
  at async main (file:///agoric/dapp-orchestration-basics/contract/scripts/deploy-contract.js:126:5)

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see fixed addresses.

(I'm mostly submitting this review to remove this from my queue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants