feat: direct user to download Keplr extension #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
782418c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a1fbf88.dapp-psm.pages.dev |
| Branch Preview URL: | https://ta-check-keplr.dapp-psm.pages.dev |
turadg
changed the title
samsiegart
requested changes
Oct 28, 2022
| @@ -0,0 +1,38 @@ | |||
| import { INTER_LOGO } from 'assets/assets'; | |||
|
|
|||
| export const hasPrerequisites = () => 'keplr' in window; | |||
There was a problem hiding this comment.
We need to ensure the window has loaded before checking this. The keplr-connection component handles this. Maybe it's time to copy that component over so we can add an error and toast for this case?
That would work differently in that the user doesn't see this indication until they actually click the button. However, I think it would be better for the app to let the user see more of the interface (i.e. view the assets without being able to input any amounts) before connecting to keplr.
There was a problem hiding this comment.
Okay, closing in favor of #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Keplr extension is available for Chrome and Firefox. Tested in both browsers.