-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unfurl image + metadata #1019
Open
0xpatrickdev
wants to merge
2
commits into
main
Choose a base branch
from
997-unfurl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
0xpatrickdev
commented
Mar 21, 2024
•
edited
Loading
edited
- closes unfurl url should have a preview image #997
Deploying documentation with Cloudflare Pages
|
dckc
force-pushed
the
pc/home-page-redesign
branch
from
March 21, 2024 16:42
2fb1224
to
2181728
Compare
0xpatrickdev
force-pushed
the
997-unfurl
branch
from
March 21, 2024 16:48
1fca1e2
to
e336b2a
Compare
dckc
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer to somebody else... @sufyaankhan ?
@@ -2,18 +2,31 @@ import { defineConfig } from 'vitepress'; | |||
import { nav } from './themeConfig/nav.js'; | |||
import { rewrites } from './themeConfig/rewrites.js'; | |||
|
|||
const SITE_TITLE = 'Agoric Documentation'; | |||
const SITE_DESCRIPTION = | |||
'The blockchain framework tailored for JavaScript developers.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any objections to this copy, but I don't think I'm a good person to approve it.
@sufyaankhan ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.